[chore] remove jpkrohling as codeowner from many modules #36563
Conversation
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
requested review from
a team,
MovieStoreGuy and
atoulme
as code owners
github-actions
bot
added
cmd/githubgen
connector/exceptions
connector/grafanacloud
connector/servicegraph
exporter/alertmanager
exporter/loki
| @@ -233,7 +233,7 @@ receiver/googlecloudspannerreceiver/ @open-telemetry/collector-cont | |||
| receiver/haproxyreceiver/ @open-telemetry/collector-contrib-approvers @atoulme @MovieStoreGuy | |||
| receiver/hostmetricsreceiver/ @open-telemetry/collector-contrib-approvers @dmitryax @braydonk | |||
| receiver/httpcheckreceiver/ @open-telemetry/collector-contrib-approvers @codeboten | |||
| receiver/huaweicloudcesreceiver/ @open-telemetry/collector-contrib-approvers @narcis96 | |||
| receiver/huaweicloudcesreceiver/ @open-telemetry/collector-contrib-approvers @heitorganzeli @narcis96 @mwear | |||
There was a problem hiding this comment.
I'm not sure how this got in, but #36258 seems to have introduced all three code owners, but this file got only one. Generating the code owners file again appears to have caught this difference.
There was a problem hiding this comment.
The following components will be unmaintained (no code owners) after this change:
- headersetter extension
- healtcheck extension
- awscloudwatchmetrics receiver
Should we mark them as unmaintained in this PR? I feel like the healthcheck extension may find new code owners easily if we ask around.
Also, no need to deal with these on this PR, but the following components will be unmaintained after open-telemetry/opentelemetry-collector#11616 is merged:
- exceptions connector
- loki receiver
At a minimum we should mark them as seeking_new: true
I'll add the seek_new to this.
This will eventually be replaced by the v2 (cc @mwear)
This is in development and abandoned by the original author. I would just remove the code we have there, as there are no users of it at the moment. I was planning on doing that on a follow-up PR.
I don't think this is a vendor-specific component. cc @marctc
I believe @mar4uk is still around for that one. |
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
No, is not. |
There was a problem hiding this comment.
Okay, I think I misremembered open-telemetry/opentelemetry-collector#11616 😅 I think the only ones we care about are the ones that have no codeowners now.
I agree with your assessment, but I think we should mark them as unmaintained to follow process. We can wait for a few days in case somebody shows up and mark as unmaintained if not
This PR removes @jpkrohling as code owner for multiple modules.
Signed-off-by: Juraci Paixão Kröhling [email protected]