Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add section for components looking for new code owners #33397

Merged
merged 6 commits into from
Jul 1, 2024

Conversation

LucaLanziani
Copy link
Contributor

Description:

Add a section to the weekly report with the list of components looking for code owners based on the status.codeowners.seeking_new property of the metadata.yaml file.

Link to tracking Issue:

#31419

Testing:

act -j get_issues  -e <(echo '{"repository": {"owner": {"login": "your-github-username"}}}') -s [GITHUB_TOKEN=](09   i0)

@LucaLanziani LucaLanziani requested review from a team and atoulme June 5, 2024 16:45
@songy23 songy23 requested a review from crobert-1 June 5, 2024 16:52
@LucaLanziani
Copy link
Contributor Author

Testing result LucaLanziani#2

Add a section to the weekly report with the list of components looking
for code owners based on the `status.codeowners.seeking_new` property of
the metadata.yaml file.
@LucaLanziani LucaLanziani force-pushed the feature/issue-31419 branch from 3340770 to 92e7a61 Compare June 10, 2024 09:23
@LucaLanziani LucaLanziani force-pushed the feature/issue-31419 branch from dc4a743 to 40b8ca7 Compare June 19, 2024 20:17
@LucaLanziani
Copy link
Contributor Author

Latest version: LucaLanziani#12

@crobert-1
Copy link
Member

Test failure is unrelated to this change, I've filed #33681.

@LucaLanziani
Copy link
Contributor Author

Next PR to reintroduce the JSON section is almost ready, waiting for this to be merged.

I wouldn't mind to refactor the code a bit after this, how about creating an issue to discuss testing options for the CI scripts so we could test the refactoring?

@crobert-1
Copy link
Member

I wouldn't mind to refactor the code a bit after this, how about creating an issue to discuss testing options for the CI scripts so we could test the refactoring?

Sounds good to me, thanks for all of your work here @LucaLanziani!

@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Jun 21, 2024
@TylerHelmuth TylerHelmuth merged commit fb3db79 into open-telemetry:main Jul 1, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants