pr review

Signed-off-by: odubajDT <[email protected]>
open-telemetry · Nov 26, 2024 · 5a5fb6a · 5a5fb6a
1 parent f72e1bf
commit 5a5fb6a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/internal/metadataproviders/kubeadm/metadata.go b/internal/metadataproviders/kubeadm/metadata.go
@@ -18,10 +18,15 @@ type Provider interface {
 	ClusterName(ctx context.Context) (string, error)
 }
 
+type LocalCache struct {
+	ClusterName string
+}
+
 type kubeadmProvider struct {
 	kubeadmClient      kubernetes.Interface
 	configMapName      string
 	configMapNamespace string
+	cache              LocalCache
 }
 
 func NewProvider(configMapName string, configMapNamespace string, apiConf k8sconfig.APIConfig) (Provider, error) {
@@ -37,10 +42,15 @@ func NewProvider(configMapName string, configMapNamespace string, apiConf k8scon
 }
 
 func (k *kubeadmProvider) ClusterName(ctx context.Context) (string, error) {
+	if k.cache.ClusterName != "" {
+		return k.cache.ClusterName, nil
+	}
 	configmap, err := k.kubeadmClient.CoreV1().ConfigMaps(k.configMapNamespace).Get(ctx, k.configMapName, metav1.GetOptions{})
 	if err != nil {
 		return "", fmt.Errorf("failed to fetch ConfigMap with name %s and namespace %s from K8s API: %w", k.configMapName, k.configMapNamespace, err)
 	}
 
+	k.cache.ClusterName = configmap.Data["clusterName"]
+
 	return configmap.Data["clusterName"], nil
 }
diff --git a/processor/resourcedetectionprocessor/README.md b/processor/resourcedetectionprocessor/README.md
@@ -434,13 +434,14 @@ Queries the K8S API server to retrieve the following resource attributes:
 
 The following permissions are required:
 ```yaml
-kind: ClusterRole
+kind: Role
 metadata:
   name: otel-collector
 rules:
   - apiGroups: [""]
     resources: ["configmaps"]
-    verbs: ["get", "list"]
+    resourceNames: ["kubeadm-config"]
+    verbs: ["get"]
 ```
 
 | Name | Type | Required | Default         | Docs                                                                                                                                                                                                                                   |