Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client-initiated certificate request flow (CSR) #162

Merged

Conversation

tigrannajaryan
Copy link
Member

@tigrannajaryan tigrannajaryan commented Jul 19, 2023

Resolves #13

Uses [Development] label as the indication of the least mature level proposed in this upcoming OTEP:
open-telemetry/oteps#232

[UPDATE]: I added a draft implementation in Go to demonstrate how the CSR flow works: open-telemetry/opamp-go#192

@tigrannajaryan tigrannajaryan requested a review from a team July 19, 2023 19:08
@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/csrflow branch 2 times, most recently from 874f0f0 to 43bbc69 Compare July 19, 2023 19:10
specification.md Outdated Show resolved Hide resolved
specification.md Outdated Show resolved Hide resolved
specification.md Show resolved Hide resolved
specification.md Show resolved Hide resolved
@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/csrflow branch from d014902 to 7488bc6 Compare July 20, 2023 23:06
specification.md Show resolved Hide resolved
@mtripathi1
Copy link

Looks good.

@tigrannajaryan
Copy link
Member Author

@open-telemetry/specs-approvers @srikanthccv please review this proposal.

I also made a draft implementation in Go to demonstrate how the CSR flow works: open-telemetry/opamp-go#192

Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will take a look at draft implementation

specification.md Outdated Show resolved Hide resolved
specification.md Outdated Show resolved Hide resolved
Copy link

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the flow looks good to me, I only have wordsmithing suggestions.

specification.md Outdated Show resolved Hide resolved
specification.md Outdated Show resolved Hide resolved
specification.md Outdated Show resolved Hide resolved
specification.md Outdated Show resolved Hide resolved
specification.md Outdated Show resolved Hide resolved
specification.md Outdated Show resolved Hide resolved
specification.md Outdated Show resolved Hide resolved
specification.md Outdated Show resolved Hide resolved
specification.md Outdated Show resolved Hide resolved
@tigrannajaryan
Copy link
Member Author

Overall the flow looks good to me, I only have wordsmithing suggestions.

Thanks @evan-bradley
All fixed.

@tigrannajaryan
Copy link
Member Author

@andykellr I wonder what you think about this, it would be great if you could take a look.

specification.md Outdated Show resolved Hide resolved
Resolves open-telemetry#13

Uses [Development] label as the indication of the least
mature level proposed in this upcoming OTEP:
open-telemetry/oteps#232
Resolves open-telemetry#13

Uses [Development] label as the indication of the least
mature level proposed in this upcoming OTEP:
open-telemetry/oteps#232
@tigrannajaryan tigrannajaryan merged commit af56fac into open-telemetry:main Sep 14, 2023
4 checks passed
@tigrannajaryan tigrannajaryan deleted the feature/tigran/csrflow branch September 14, 2023 14:43
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this pull request Oct 18, 2023
- Implemented spec change open-telemetry/opamp-spec#162
- Added ability for the client to request connection settings.
- Added CSR flow example to demonstrate the new capability.
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this pull request Oct 18, 2023
- Implemented spec change open-telemetry/opamp-spec#162
- Added ability for the client to request connection settings.
- Added CSR flow example to demonstrate the new capability.
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this pull request Oct 18, 2023
- Implemented spec change open-telemetry/opamp-spec#162
- Added ability for the client to request connection settings.
- Added CSR flow example to demonstrate the new capability.
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this pull request Oct 18, 2023
- Implemented spec change open-telemetry/opamp-spec#162
- Added ability for the client to request connection settings.
- Added CSR flow example to demonstrate the new capability.
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this pull request Oct 18, 2023
- Implemented spec change open-telemetry/opamp-spec#162
- Added ability for the client to request connection settings.
- Added CSR flow example to demonstrate the new capability.
tigrannajaryan added a commit to open-telemetry/opamp-go that referenced this pull request Nov 6, 2023
- Implemented spec change open-telemetry/opamp-spec#162
- Added ability for the client to request connection settings.
- Added CSR flow example to demonstrate the new capability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider an alternate certificate renewal flow that uses CSR
5 participants