Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Portuguese translation #235

Closed
wants to merge 2 commits into from
Closed

Conversation

venelouis
Copy link

@venelouis venelouis commented Aug 11, 2024

Description

Add Portuguese translation: https://github.com/venelouis/intro/tree/pt-translations
Here you can see the changes: https://github.com/open-sauced/intro/pull/235/files

Related Tickets & Documents

Docs #234

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

  1. See the modifications: https://github.com/open-sauced/intro/pull/235/files
  2. Compare
  3. Merge if you agree

Added to documentation?
[x ] 📜 README.md

Our discussion link for Portuguese repo: venelouis#1
The changes I made: https://github.com/open-sauced/intro/pull/235/files

What type of PR is this? (check all applicable)
[x ] 🍕 Feature
[ x] 📝 Documentation Update

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

🇧🇷 🇵🇹 😃
image

@venelouis venelouis requested a review from a team as a code owner August 11, 2024 17:32
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We would suggest that you close this PR and implement your changes as described in our Contributing Guide and open a new pull request.

Copy link

netlify bot commented Aug 11, 2024

Deploy Preview for learn-opensauced ready!

Name Link
🔨 Latest commit 850670e
🔍 Latest deploy log https://app.netlify.com/sites/learn-opensauced/deploys/66b905f7e7c21b00083feeb9
😎 Deploy Preview https://deploy-preview-235--learn-opensauced.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@venelouis
Copy link
Author

I really don't know how to solve this, anyone can help me please?

@venelouis venelouis marked this pull request as draft August 11, 2024 18:04
@venelouis venelouis marked this pull request as ready for review August 11, 2024 18:09
@venelouis venelouis changed the title Add Portuguese translation feat: Add Portuguese translation Aug 11, 2024
@venelouis
Copy link
Author

ok, now my pr it is green at least \o/ ✅

@CBID2
Copy link
Contributor

CBID2 commented Aug 12, 2024

Hi @venelouis. There are guidelines for translating the course into different languages. I highly recommend closing this Pull Request and reading it.

@venelouis
Copy link
Author

@CBID2 yes I know, I read all. Is there anything wrong with my PR?

@CBID2
Copy link
Contributor

CBID2 commented Aug 12, 2024

@CBID2 yes I know, I read all. Is there anything wrong with my PR?

Yes, to simplify why, check out this announcement: #190

Note

It applies to translating in general

@venelouis
Copy link
Author

@CBID2 I see there a Spanish community translation right? Why isn't it there, how did I put mine? I don't understand, from what I understand I think I did everything right.

@CBID2
Copy link
Contributor

CBID2 commented Aug 12, 2024

@CBID2 I see there a Spanish community translation right? Why isn't it there, how did I put mine? I don't understand, from what I understand I think I did everything right.

You going to have to deploy it separately. @adiati98, can you explain a bit more about the translation process?

@samucodesh
Copy link
Contributor

@CBID2 I see there a Spanish community translation right? Why isn't it there, how did I put mine? I don't understand, from what I understand I think I did everything right.

Hello @venelouis

I strongly recommend using this issue as a reference point for the translation.

@venelouis
Copy link
Author

venelouis commented Aug 12, 2024

Yes I know, @samucodesh but you profile and link shouldn't they be on the list?

@venelouis venelouis closed this Aug 12, 2024
@samucodesh
Copy link
Contributor

Yes I know, @samucodesh but you profile and link shouldn't they be on the list?

Hello @venelouis

My profile is currently unavailable due to ongoing project migration and translation. The repository has undergone multiple refactoring processes, and my current work is based on a previous version.

@venelouis
Copy link
Author

Thank you @samucodesh and @CBID2. Sorry about any inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants