feat: use async hooks and beta api #296
Conversation
✅ Deploy Preview for hot-sauced-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| } | ||
|
|
||
| setVotedReposIds([]); | ||
| }, []); |
There was a problem hiding this comment.
Should the data.votes be set here as the watch data?
There was a problem hiding this comment.
thought about it, but then all the vote functions we are re-using modify the votedReposIds globally, so we only need to fetch the recommendations on load - it will make even more sense with SWR or "my votes call" and local storage cache;
That would make the votes available on refresh even without fetching the data again, and provide integrity with voted data throughout the UI, still, not hitting the SWR revalidation.
That's the plan, at least! 🍕
|
I was looking at this and saw the deploy preview currently returns the white screen of death. |
Oh yeah, I made the not logged in checks too lax and then focused on finishing the votes - made the upvote work sometime today but got left with an unstated "voted/upvote" button, will drop the fix for not logged in along with that, almost done with the hero repos. When that happens it won't be a draft anymore 🍕 |
|
Have you considered adding the preloader for |
Yes, however that one doesn't use SWR, a correct preload mechanism there is to animate React loading skeleton package is a bit more useful than dropping a circle loading spinner, however it requires stateful data loading, something we get with API+SWR, right now using supabase js we would have to implement that manually. Will check the best way to display at least one skeleton in the post list and alert the user on clicking load more. 🍕 |
|
@open-sauced/triage take a look at this and confirm data renders |
|
🎉 This PR is included in version 2.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* origin/main: chore(patch): release 2.23.3 [skip ci] fix: correct swr fetcher not throwing on error (#306) chore(patch): release 2.23.2 [skip ci] fix: load more doesn't load repositories (#304) chore(patch): release 2.23.1 [skip ci] fix: dedupe app global user state (#303) chore(minor): release 2.23.0 [skip ci] feat: change title font to open sans bold (#300) chore(minor): release 2.22.0 [skip ci] feat: updated css to respect row in subnav (#298) feat: use async hooks and beta api for hot repos (#296)
* origin/main: (117 commits) chore(patch): release 2.23.3 [skip ci] fix: correct swr fetcher not throwing on error (#306) chore(patch): release 2.23.2 [skip ci] fix: load more doesn't load repositories (#304) chore(patch): release 2.23.1 [skip ci] fix: dedupe app global user state (#303) chore(minor): release 2.23.0 [skip ci] feat: change title font to open sans bold (#300) chore(minor): release 2.22.0 [skip ci] feat: updated css to respect row in subnav (#298) feat: use async hooks and beta api for hot repos (#296) chore(patch): release 2.21.2 [skip ci] fix(vite.config.ts): correct font loading preload (#294) chore(patch): release 2.21.1 [skip ci] fix: dedupe handleVoteUpdateByRepo function (#292) chore(minor): release 2.21.0 [skip ci] chore(minor): release 2.20.0 [skip ci] feat: make the contributors StackedAvatars component reusable (#290) chore(minor): release 2.19.0 [skip ci] feat: added system notification (#285) ...
|
🎉 This PR is included in version 2.24.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What type of PR is this? (check all applicable)
Description
This PR adds
useSWRdata loading hooks with loading and a minimalHotRepositories.tsxhttps://beta.api.opensauced.pizza/docs implementation.Related Tickets & Documents
closes #270
closes #272
closes #276
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?