Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add my name #137

Merged
merged 4 commits into from
Oct 20, 2023
Merged

feat: add my name #137

merged 4 commits into from
Oct 20, 2023

Conversation

Lymah123
Copy link
Contributor

Description

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@Lymah123
Copy link
Contributor Author

Hi @CBID2 :)!

@CBID2 CBID2 enabled auto-merge (squash) October 20, 2023 05:34
@CBID2
Copy link
Contributor

CBID2 commented Oct 20, 2023

Hi @CBID2 :)!

Hi @Lymah123! πŸ˜ƒ You did great in the first part. Now, you just have to follow the other steps to add your name to the README: https://github.com/open-sauced/guestbook/blob/main/README.md

@Lymah123
Copy link
Contributor Author

Hi @CBID2 :)!

Hi @Lymah123! πŸ˜ƒ You did great in the first part. Now, you just have to follow the other steps to add it to the README:
Alright, thank you!

auto-merge was automatically disabled October 20, 2023 06:51

Head branch was pushed to by a user without write access

@Lymah123
Copy link
Contributor Author

I have made update @CBID2 .

Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2 CBID2 merged commit 2068028 into open-sauced:main Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants