WIP feat: error groups #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: #225
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #225
It does have some implications on tooling - tooling would need to parse these refs, as well as union the errors based on their error code.
This is slightly departed from regular pattern of components being 1-to-1 with Foo-Object where foo is something like method, content descriptor, etc. If we have an ErrorGroupsObject, it would be a lie, since its an array. So this would introduce a ErrorGroupsArray, and then you ask, why would we ever put an error group in a method... its entire purpose is reuse. That took me full circle back to this. It seems the most simple, and the least in your way if you dont care about it.