Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update schema according to latest spec #170

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

peol
Copy link
Contributor

@peol peol commented Jan 14, 2020

This PR syncs the schema with the latest documented specification (as far as I can find, at least).

Fixes #156

@BelfordZ
Copy link
Member

BelfordZ commented Jan 15, 2020

@peol Happy to move forward with the fixes that have already landed in the spec.

Otherrwise, this will have to wait until we have got things finalized there.

Thank you very much for the PR, <3

@peol
Copy link
Contributor Author

peol commented Jan 15, 2020

@BelfordZ Sure, I'll remove errorGroups for now, I just included it since we're depending on that mechanism being supported and thought it might help move it along :)

@peol peol force-pushed the updates-from-spec branch 2 times, most recently from 1128ea3 to ef91674 Compare January 15, 2020 08:43
BelfordZ
BelfordZ previously approved these changes Jan 16, 2020
@BelfordZ
Copy link
Member

@peol If you have a chance, could you please sign your commit? Its one of the master branch protection rules for all of the open rpc repos. This is because we hope that you stick around and continue to contribute, and by signing your commits we can be sure that your next contrib is made by the same person that made this one. :)

Thanks again for the PR!

@BelfordZ BelfordZ added bug Something isn't working enhancement New feature or request labels Jan 16, 2020
@peol
Copy link
Contributor Author

peol commented Jan 16, 2020

@BelfordZ Sure, I've rebased with a signed commit now :)

@BelfordZ BelfordZ merged commit 7561be6 into open-rpc:master Jan 16, 2020
@peol peol deleted the updates-from-spec branch January 16, 2020 08:19
@openrpc-bastion
Copy link
Member

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update meta schema to reflect latest OpenRPC spec
3 participants