develop: Add field to RobotState to track command completion #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature implementation
Implemented feature
Added
command_completed
, a boolean that indicates the completion of the current command.Implementation description
Previously, if a command was completed, the RobotState's
command_id
should be a nullopt. This led to the issue where if a new command is issued and instantly completed, the following RobotState would have a nullcommand_id
and users of the free_fleet Manager would be unable to determine if the command was successful or was not received.With the new
command_completed
field, the completion status is explicit andcommand_id
always has the id of the latest command.