Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop: Add field to RobotState to track command completion #114

Closed

Conversation

chianfern
Copy link

New feature implementation

Implemented feature

Added command_completed, a boolean that indicates the completion of the current command.

Implementation description

Previously, if a command was completed, the RobotState's command_id should be a nullopt. This led to the issue where if a new command is issued and instantly completed, the following RobotState would have a null command_id and users of the free_fleet Manager would be unable to determine if the command was successful or was not received.

With the new command_completed field, the completion status is explicit and command_id always has the id of the latest command.

Signed-off-by: chianfern <[email protected]>
Signed-off-by: chianfern <[email protected]>
@chianfern chianfern changed the title Add field to RobotState to track command completion develop: Add field to RobotState to track command completion Dec 23, 2021
@aaronchongth
Copy link
Member

Closing with #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants