Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize #19

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Modernize #19

wants to merge 22 commits into from

Conversation

hannesa2
Copy link
Contributor

Please see commit messages for details

@Valodim
Copy link
Member

Valodim commented Aug 23, 2021

looks good to me, thanks 👍 I'll check it out on my machine later then merge

@hannesa2
Copy link
Contributor Author

I see, it's not that easy to test on CI. A OpenPGP app is required
image

@hannesa2
Copy link
Contributor Author

hannesa2 commented Sep 9, 2021

looks good to me, thanks 👍 I'll check it out on my machine later then merge

@Valodim ?

@hannesa2
Copy link
Contributor Author

It's a pre work for modernize https://github.com/open-keychain/open-keychain
@Valodim

@brendanpward
Copy link

Worked well for me but had to update AndroidManifest.xml to include the following:

    <queries>
        <package android:name="org.sufficientlysecure.keychain" />
    </queries>

@hannesa2
Copy link
Contributor Author

Surprisingly, someone takes care about this pull request !

@brendanpward

  • In which issue do you run without your change ?
  • In which module do you added it ?

hannesa2 and others added 2 commits August 13, 2024 11:31
Without this option, bindToService fails on newer Android API versions.
@brendanpward
Copy link

Surprisingly, someone takes care about this pull request !

@brendanpward

  • In which issue do you run without your change ?
  • In which module do you added it ?

I was having issues running the example application as it wouldn't connect to OpenKeychain. It wouldn't see OpenKeychain. As soon as I added this option, I was able to select OpenKeychain as my encryption provider. I sent you a PR with the recommended change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants