feat: Add ProviderNotReady event #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
commented
Jan 30, 2024
fabriziodemaria
force-pushed
the
not-ready
branch
from
74ff8b3 to
fc98316
Compare
vahidlazio
reviewed
Jan 30, 2024
nicklasl
approved these changes
Feb 2, 2024
fabriziodemaria
force-pushed
the
not-ready
branch
from
fc98316 to
4aa6636
Compare
Signed-off-by: Fabrizio Demaria <[email protected]>
fabriziodemaria
force-pushed
the
not-ready
branch
from
4aa6636 to
3c5021c
Compare
fabriziodemaria
pushed a commit
that referenced
this pull request
Feb 2, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](0.0.2...0.1.0) (2024-02-02) ### ⚠ BREAKING CHANGES * Add EventHandler + Combine ([#29](#29)) ### 🐛 Bug Fixes * setProviderAndWait does not hang on ProviderError ([#35](#35)) ([5661080](5661080)) ### ✨ New Features * Add ProviderNotReady event ([#36](#36)) ([389f117](389f117)) * Add setProviderAndWait ([#30](#30)) ([3ce6b8d](3ce6b8d)) ### 🧹 Chore * **deps:** update actions/checkout action to v4 ([#18](#18)) ([eb0cd56](eb0cd56)) * **deps:** update dependency apple/swift-format to v509 ([#21](#21)) ([5f12304](5f12304)) * Smaller cleanup in tests ([#33](#33)) ([053dabc](053dabc)) ### 📚 Documentation * add sections for logging, named providers, and shutdown ([#31](#31)) ([dc5876c](dc5876c)) * Fix Installation documentation ([#27](#27)) ([5ddf45d](5ddf45d)), closes [#25](#25) * Update README to latest template ([#28](#28)) ([dbdd502](dbdd502)) * Update README.md ([#19](#19)) ([ec599ff](ec599ff)) ### 🔄 Refactoring * Add EventHandler + Combine ([#29](#29)) ([dd122f7](dd122f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specs define separately provider EVENTS and provider STATUS. This PR doesn't quite yet introduce
ProviderStatus, but rather extends the Events to include all the possible statuses (namely addingnotReady). I am not sure if this compromise can be acceptable in the long run, or if we'll need to eventually add the Statuses separately. Nevertheless addingnotReadygives the Providers a proper case to use at initialization time.Related Issues
Shall we add the lack ofProviderStatusas an Issue?(There is a proposal to remove ProviderStatus from Provider)