fix: setProviderAndWait does not hang on ProviderError #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickybondarenko
force-pushed
the
setproviderandwait-on-failure
branch
from
c0560c2 to
5fb88d9
Compare
vahidlazio
reviewed
Jan 30, 2024
vahidlazio
reviewed
Jan 30, 2024
vahidlazio
reviewed
Jan 30, 2024
nickybondarenko
force-pushed
the
setproviderandwait-on-failure
branch
from
5fb88d9 to
54340e2
Compare
Signed-off-by: Nicky Bondarenko <[email protected]>
nickybondarenko
force-pushed
the
setproviderandwait-on-failure
branch
from
54340e2 to
f4200c8
Compare
vahidlazio
approved these changes
Jan 30, 2024
fabriziodemaria
pushed a commit
that referenced
this pull request
Feb 2, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](0.0.2...0.1.0) (2024-02-02) ### ⚠ BREAKING CHANGES * Add EventHandler + Combine ([#29](#29)) ### 🐛 Bug Fixes * setProviderAndWait does not hang on ProviderError ([#35](#35)) ([5661080](5661080)) ### ✨ New Features * Add ProviderNotReady event ([#36](#36)) ([389f117](389f117)) * Add setProviderAndWait ([#30](#30)) ([3ce6b8d](3ce6b8d)) ### 🧹 Chore * **deps:** update actions/checkout action to v4 ([#18](#18)) ([eb0cd56](eb0cd56)) * **deps:** update dependency apple/swift-format to v509 ([#21](#21)) ([5f12304](5f12304)) * Smaller cleanup in tests ([#33](#33)) ([053dabc](053dabc)) ### 📚 Documentation * add sections for logging, named providers, and shutdown ([#31](#31)) ([dc5876c](dc5876c)) * Fix Installation documentation ([#27](#27)) ([5ddf45d](5ddf45d)), closes [#25](#25) * Update README to latest template ([#28](#28)) ([dbdd502](dbdd502)) * Update README.md ([#19](#19)) ([ec599ff](ec599ff)) ### 🔄 Refactoring * Add EventHandler + Combine ([#29](#29)) ([dd122f7](dd122f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
setProviderAndWaitreturns ifProviderErrorevent has been emittedRelated Issues
N/A
How to test
Unit test added