feat: add basic gherkin test suite for tracking feature (WIP) #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warber
force-pushed
the
feat/gherkin-tracking
branch
from
531660a to
82cb824
Compare
warber
force-pushed
the
feat/gherkin-tracking
branch
from
82cb824 to
cb850eb
Compare
Signed-off-by: Bernd Warmuth <[email protected]>
warber
force-pushed
the
feat/gherkin-tracking
branch
from
cb850eb to
5af836f
Compare
aepfli
reviewed
Dec 9, 2024
| | "" | | ||
| | "NULL" | | ||
|
|
||
| Scenario Outline: Provider's track functionality is called |
There was a problem hiding this comment.
The track API is rich not just an event_name - hence this gherkin file should also test the other cases properly, with information enrichment (if there is some) - https://openfeature.dev/specification/sections/tracking#conditional-requirement-6111 and this would actually be already a test verifying this specification.
We can also reuse the step from the flags (https://github.com/open-feature/spec/blob/main/specification/assets/gherkin/evaluation.feature#L53)
When context contains keys "fn", "ln", "age", "customer" with values "Sulisław", "Świętopełk", 29, "false"
There was a problem hiding this comment.
maybe we are also able to write a scenario for https://openfeature.dev/specification/sections/tracking#requirement-614
warber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds basic gherkin test suite to test behaviour of the tracking feature.
For now only the handling of the optional tracking event name is covered.