Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix attrs dependency issue #27

Closed
wants to merge 1 commit into from
Closed

chore: fix attrs dependency issue #27

wants to merge 1 commit into from

Conversation

agardnerIT
Copy link
Contributor

Related Issues

Fixes #26

Notes

Follow-up Tasks

How to test

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #27 (9b8718c) into main (0e912ad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   87.20%   87.20%           
=======================================
  Files           8        8           
  Lines         125      125           
=======================================
  Hits          109      109           
  Misses         16       16           
Flag Coverage Δ
unittests 87.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -1,3 +1,4 @@
attrs==23.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to pin the version? This appears to be the latest version.

@beeme1mr beeme1mr requested a review from federicobond October 3, 2023 15:28
@federicobond
Copy link
Member

Thank you! This changeset was superseeded by #28 which simplified a lot of the dependency configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dev dependencies
3 participants