refactor!: update imports to the latest version of the sdk #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 28, 2023
Closed
Closed
beeme1mr
approved these changes
Sep 28, 2023
|
@federicobond I've merged and released the updated SDK. |
Signed-off-by: Federico Bond <[email protected]>
federicobond
force-pushed
the
update-imports
branch
from
51ca866 to
5ff868c
Compare
Codecov Report
@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 83.00% 83.00%
=======================================
Files 7 7
Lines 100 100
=======================================
Hits 83 83
Misses 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
odubajDT
approved these changes
Sep 28, 2023
|
Thank you for contribution! :) |
|
@beeme1mr awesome! merging now that tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Updates imports to the latest version of the Python SDK. It also places the contrib code under the
openfeature.contribnamespace. For this to work,openfeaturehas to be turned into an implicit namespace package by removing the__init__.pyfile in the sdk (see open-feature/python-sdk#199).Notes
This requires open-feature/python-sdk#199 to be merged first for the shared namespace to work.