Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removes exports of OpenFeatureClient class and makes event props readonly #918

Merged
merged 2 commits into from
May 2, 2024
Merged

fix: removes exports of OpenFeatureClient class and makes event props readonly #918

merged 2 commits into from
May 2, 2024

Conversation

lukas-reining
Copy link
Member

This PR

Removes OpenFeatureClient class from exports and makes event details readonly as described here: #799

@lukas-reining lukas-reining requested a review from a team as a code owner April 25, 2024 17:10
@lukas-reining lukas-reining force-pushed the fix/exports-and-readonly branch from 303986c to f2a8cb5 Compare April 25, 2024 17:13
@lukas-reining lukas-reining enabled auto-merge May 2, 2024 14:35
@lukas-reining lukas-reining added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit e9a25c2 May 2, 2024
9 checks passed
@lukas-reining lukas-reining deleted the fix/exports-and-readonly branch May 2, 2024 14:38
This was referenced May 2, 2024
Merged
Merged
Merged
Merged
@toddbaert
Copy link
Member

Thanks @lukas-reining . I'll release these tomorrow.

github-merge-queue bot pushed a commit that referenced this pull request May 13, 2024
@openfeaturebot @toddbaert
chore(main): release core 1.2.0 (#927)
692ad5b 
🤖 I have created a release *beep* *boop*
---


##
[1.2.0](core-v1.1.0...core-v1.2.0)
(2024-05-13)


### ✨ New Features

* set context during provider init on web
([#919](#919))
([7e6c1c6](7e6c1c6))


### 🐛 Bug Fixes

* removes exports of OpenFeatureClient class and makes event props
readonly ([#918](#918))
([e9a25c2](e9a25c2))
* run error hook when provider returns reason error or error code
([#926](#926))
([c6d0b5d](c6d0b5d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: openfeature-peer-update-bot <[email protected]>
Co-authored-by: openfeature-peer-update-bot <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
toddbaert added a commit that referenced this pull request May 13, 2024
@openfeaturebot @toddbaert
chore(main): release server-sdk 1.14.0 (#930)
f2ebd11 
🤖 I have created a release *beep* *boop*
---


##
[1.14.0](server-sdk-v1.13.5...server-sdk-v1.14.0)
(2024-05-13)


### 🐛 Bug Fixes

* remove export of OpenFeatureClient
([#794](#794))
([3d197f2](3d197f2))
* removes exports of OpenFeatureClient class and makes event props
readonly ([#918](#918))
([e9a25c2](e9a25c2))
* run error hook when provider returns reason error or error code
([#926](#926))
([c6d0b5d](c6d0b5d))


### 🧹 Chore

* remove node 16
([#875](#875))
([c1878e4](c1878e4))
* **main:** release core 1.2.0
([#927](#927))
([692ad5b](692ad5b))


### 📚 Documentation

* add tip about supported usage in the install section
([#941](#941))
([f0de667](f0de667))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
toddbaert added a commit that referenced this pull request May 13, 2024
@openfeaturebot @toddbaert
chore(main): release web-sdk 1.1.0 (#929)
ee08911 
🤖 I have created a release *beep* *boop*
---


##
[1.1.0](web-sdk-v1.0.3...web-sdk-v1.1.0)
(2024-05-13)


### ✨ New Features

* set context during provider init on web
([#919](#919))
([7e6c1c6](7e6c1c6))


### 🐛 Bug Fixes

* remove export of OpenFeatureClient
([#794](#794))
([3d197f2](3d197f2))
* removes exports of OpenFeatureClient class and makes event props
readonly ([#918](#918))
([e9a25c2](e9a25c2))
* run error hook when provider returns reason error or error code
([#926](#926))
([c6d0b5d](c6d0b5d))
* skip reconciling event for synchronous onContextChange operations
([#931](#931))
([6c25f29](6c25f29))


### 🧹 Chore

* **main:** release core 1.2.0
([#927](#927))
([692ad5b](692ad5b))


### 📚 Documentation

* add tip about supported usage in the install section
([#941](#941))
([f0de667](f0de667))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
toddbaert added a commit that referenced this pull request May 13, 2024
@openfeaturebot @toddbaert
chore(main): release nestjs-sdk 0.1.5-experimental (#928)
988a1f7 
🤖 I have created a release *beep* *boop*
---


##
[0.1.5-experimental](nestjs-sdk-v0.1.4-experimental...nestjs-sdk-v0.1.5-experimental)
(2024-05-13)


### 🐛 Bug Fixes

* removes exports of OpenFeatureClient class and makes event props
readonly ([#918](#918))
([e9a25c2](e9a25c2))


### 🧹 Chore

* remove node 16
([#875](#875))
([c1878e4](c1878e4))
* **deps:** update dependency supertest to v7
([#939](#939))
([9083df8](9083df8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
@lukas-reining lukas-reining mentioned this pull request May 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 19, 2024
@lukas-reining
feat!: rename FeatureClient decorator to OpenFeatureClient (#949)
a531238 
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

As discussed here
[#750](#750 (comment)),
renames `@FeatureClient` to `@OpenFeatureClient` which is possible since
we merged #918.

Signed-off-by: Lukas Reining <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaspoignant thomaspoignant thomaspoignant approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

@toddbaert toddbaert Awaiting requested review from toddbaert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukas-reining @toddbaert @beeme1mr @thomaspoignant