Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: maintain state in SDK, add RECONCILING #795

Merged
merged 10 commits into from
Mar 1, 2024
Merged

feat: maintain state in SDK, add RECONCILING #795

merged 10 commits into from
Mar 1, 2024

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Jan 29, 2024 •
edited
Loading

Implements the newest spec changes here.

  • Provider state is deprecated (state is now maintained in the SDK itself). This is non-breaking, we just ignore the provider's own state now
  • add RECONCILING events and state, fire related events with provider's on context change
  • add FATAL state

The new tests should help you understand the impact of the changes.

@toddbaert toddbaert requested a review from a team as a code owner January 29, 2024 20:45
@toddbaert toddbaert marked this pull request as draft January 29, 2024 20:45
@toddbaert toddbaert force-pushed the deprecate-status branch 2 times, most recently from baafc3b to e8dcc3f Compare January 29, 2024 21:01
@toddbaert toddbaert changed the title [PoC] feat!: deprecate status, run stale automatically feat!: deprecate status, run stale automatically Jan 29, 2024
@toddbaert toddbaert mentioned this pull request Jan 29, 2024
Closed
@toddbaert toddbaert force-pushed the deprecate-status branch 5 times, most recently from c107127 to cf1176b Compare February 5, 2024 16:45
@toddbaert toddbaert changed the title feat!: deprecate status, run stale automatically feat!: rm status from provider, run stale in SDK Feb 5, 2024
@toddbaert toddbaert force-pushed the deprecate-status branch 2 times, most recently from 53fbff5 to f83aaaa Compare February 5, 2024 17:35
@toddbaert toddbaert changed the title feat!: rm status from provider, run stale in SDK feat!: implement latest spec Feb 22, 2024
@toddbaert toddbaert force-pushed the deprecate-status branch 2 times, most recently from 98bbf2c to 0407a30 Compare February 23, 2024 15:56
@toddbaert toddbaert changed the title feat!: implement latest spec feat: SDK maintains state, add reconciling Feb 23, 2024
@toddbaert toddbaert mentioned this pull request Feb 26, 2024
Merged
@toddbaert toddbaert marked this pull request as ready for review February 26, 2024 16:40
@toddbaert toddbaert requested a review from liran2000 February 27, 2024 13:53
@toddbaert
fixup: lint
6197343 
Signed-off-by: Todd Baert <[email protected]>
@toddbaert
Copy link
Member Author

@lukas-reining thanks for the great review. I've resolved some of your smaller comments, and left a few others open for your re-review.

beeme1mr
beeme1mr reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the provider section in the client and server readmes.

lukas-reining
lukas-reining approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
@toddbaert I will do the other spec change (context propagation) in another PR, which will basically just be refining the current implementation.

@toddbaert
Copy link
Member Author

toddbaert commented Feb 27, 2024 •
edited
Loading

Please update the provider section in the client and server readmes.

Good point. I removed the provider status there.

@toddbaert
fixup: readme
77d409c 
Signed-off-by: Todd Baert <[email protected]>
@toddbaert toddbaert requested a review from beeme1mr February 27, 2024 19:12
@toddbaert toddbaert changed the title feat: SDK maintains state, add reconciling feat: maintain state in SDK, add RECONCILING Feb 28, 2024
@toddbaert
fixup: naming, comment
8fe0aee 
Signed-off-by: Todd Baert <[email protected]>
@toddbaert toddbaert added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit cfb0a69 Mar 1, 2024
9 checks passed
@toddbaert toddbaert deleted the deprecate-status branch March 1, 2024 14:10
This was referenced Mar 1, 2024
Merged
Merged
Merged
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2024
@openfeaturebot @toddbaert
chore(main): release core 0.0.27 (#839)
ccbb1f9 
🤖 I have created a release *beep* *boop*
---


##
[0.0.27](core-v0.0.26...core-v0.0.27)
(2024-03-05)


### ✨ New Features

* maintain state in SDK, add RECONCILING
([#795](#795))
([cfb0a69](cfb0a69))


### 🐛 Bug Fixes

* allow iteration over all event types
([#844](#844))
([411c7b4](411c7b4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: openfeature-peer-update-bot <[email protected]>
Co-authored-by: openfeature-peer-update-bot <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2024
@openfeaturebot
chore(main): release server-sdk 1.13.0 (#841)
b3d7f37 
🤖 I have created a release *beep* *boop*
---


##
[1.13.0](server-sdk-v1.12.0...server-sdk-v1.13.0)
(2024-03-05)


### ✨ New Features

* context propagation
([#837](#837))
([b1abef1](b1abef1))
* maintain state in SDK, add RECONCILING
([#795](#795))
([cfb0a69](cfb0a69))


### 🐛 Bug Fixes

* allow iteration over all event types
([#844](#844))
([411c7b4](411c7b4))
* correct rollup to bundle all but core
([#846](#846))
([f451e25](f451e25))


### 🧹 Chore

* **main:** release core 0.0.27
([#839](#839))
([ccbb1f9](ccbb1f9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2024
@openfeaturebot @toddbaert
chore(main): release web-sdk 0.4.14 (#840)
21f72b9 
🤖 I have created a release *beep* *boop*
---


##
[0.4.14](web-sdk-v0.4.13...web-sdk-v0.4.14)
(2024-03-05)


### ✨ New Features

* maintain state in SDK, add RECONCILING
([#795](#795))
([cfb0a69](cfb0a69))
* suspend on RECONCILING, mem provider fixes
([#796](#796))
([8101ff1](8101ff1))


### 🐛 Bug Fixes

* allow iteration over all event types
([#844](#844))
([411c7b4](411c7b4))
* correct rollup to bundle all but core
([#846](#846))
([f451e25](f451e25))


### 🧹 Chore

* **main:** release core 0.0.27
([#839](#839))
([ccbb1f9](ccbb1f9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2024
@openfeaturebot
chore(main): release nestjs-sdk 0.1.1-experimental (#842)
a37a33c 
🤖 I have created a release *beep* *boop*
---


##
[0.1.1-experimental](nestjs-sdk-v0.1.0-experimental...nestjs-sdk-v0.1.1-experimental)
(2024-03-05)


### ✨ New Features

* context propagation
([#837](#837))
([b1abef1](b1abef1))
* maintain state in SDK, add RECONCILING
([#795](#795))
([cfb0a69](cfb0a69))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
toddbaert pushed a commit that referenced this pull request Mar 5, 2024
@openfeaturebot
chore(main): release react-sdk 0.2.1-experimental (#843)
1461074 
🤖 I have created a release *beep* *boop*
---


##
[0.2.1-experimental](react-sdk-v0.2.0-experimental...react-sdk-v0.2.1-experimental)
(2024-03-05)


### ✨ New Features

* maintain state in SDK, add RECONCILING
([#795](#795))
([cfb0a69](cfb0a69))
* suspend on RECONCILING, mem provider fixes
([#796](#796))
([8101ff1](8101ff1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
This was referenced Mar 12, 2024
Closed
Closed
@toddbaert toddbaert mentioned this pull request May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukas-reining lukas-reining lukas-reining approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

@luizgribeiro luizgribeiro Awaiting requested review from luizgribeiro

@thomaspoignant thomaspoignant Awaiting requested review from thomaspoignant

@liran2000 liran2000 Awaiting requested review from liran2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toddbaert @beeme1mr @lukas-reining