Skip to content

Commit

Permalink
Merge pull request #57 from open-feature/remove-snapshot-via-maven
Browse files Browse the repository at this point in the history
use mvn version to remove -SNAPSHOT, bump 0.1.1
  • Loading branch information
toddbaert authored Sep 4, 2022
2 parents d5bd0fb + 0d6ae8c commit c701a6c
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,14 @@ jobs:
echo -n "$GPG_SIGNING_KEY" | base64 --decode | gpg --import
env:
GPG_SIGNING_KEY: ${{ secrets.GPG_SIGNING_KEY }}

- name: Remove SNAPSHOT
run: mvn versions:set -DremoveSnapshot

- name: Deploy
run: |
run: |
mvn --batch-mode \
--settings release/m2-settings.xml clean deploy -Dversion.modifier=''
--settings release/m2-settings.xml clean deploy
env:
OSSRH_USERNAME: ${{ secrets.OSSRH_USERNAME }}
OSSRH_PASSWORD: ${{ secrets.OSSRH_PASSWORD }}
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class MyClass {
<dependency>
<groupId>dev.openfeature</groupId>
<artifactId>javasdk</artifactId>
<version>0.1.0</version>
<version>0.1.1</version>
</dependency>
```

Expand All @@ -87,7 +87,7 @@ If you would like snapshot builds, this is the relevant repository information:
#### Gradle
```groovy
dependencies {
implementation 'dev.openfeature:javasdk:0.1.0'
implementation 'dev.openfeature:javasdk:0.1.1'
}
```

Expand Down
4 changes: 1 addition & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,9 @@

<groupId>dev.openfeature</groupId>
<artifactId>javasdk</artifactId>
<version>0.1.0${version.modifier}</version>
<version>0.1.1-SNAPSHOT</version>

<properties>
<!-- During releases, we override this to make it empty -->
<version.modifier>-SNAPSHOT</version.modifier>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>${maven.compiler.source}</maven.compiler.target>
Expand Down

0 comments on commit c701a6c

Please sign in to comment.