feat: Add Statsig provider #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ders/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/ContextTransformer.java
Outdated
Show resolved
Hide resolved
...ders/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/ContextTransformer.java
Outdated
Show resolved
Hide resolved
providers/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/StatsigProvider.java
Outdated
Show resolved
Hide resolved
providers/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/StatsigProvider.java
Outdated
Show resolved
Hide resolved
providers/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/StatsigProvider.java
Outdated
Show resolved
Hide resolved
providers/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/StatsigProvider.java
Outdated
Show resolved
Hide resolved
providers/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/StatsigProvider.java
Outdated
Show resolved
Hide resolved
providers/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/StatsigProvider.java
Outdated
Show resolved
Hide resolved
providers/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/StatsigProvider.java
Show resolved
Hide resolved
providers/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/StatsigProvider.java
Outdated
Show resolved
Hide resolved
providers/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/StatsigProvider.java
Show resolved
Hide resolved
toddbaert
reviewed
Jan 31, 2024
...ders/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/ContextTransformer.java
Show resolved
Hide resolved
toddbaert
previously approved these changes
Jan 31, 2024
There was a problem hiding this comment.
LGTM @liran2000 , thanks again.
@xinlili-statsig are you interested in being added to the component_owners for this component? It will mean you are added to PRs that impact it. Note you will have to join the OpenFeature org in that case.
@liran2000 please add yourself to https://github.com/open-feature/java-sdk-contrib/blob/main/.github/component_owners.yml for this at a minimum.
Also, you may be interested in this issue since you've authored quite a few providers.
toddbaert
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Hey @liran2000 I led you wrong, I said to use InvalidContextError but we have TargetingKeyMissingError, so I recommend that... so I made that change. Sorry!
...ders/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/ContextTransformer.java
Outdated
Show resolved
Hide resolved
...ders/statsig/src/main/java/dev/openfeature/contrib/providers/statsig/ContextTransformer.java
Outdated
Show resolved
Hide resolved
|
@Kavindu-Dodan when you have a moment, please review and feel free to merge if it looks OK. |
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
…ers/statsig/ContextTransformer.java Signed-off-by: Todd Baert <[email protected]>
…ers/statsig/ContextTransformer.java Signed-off-by: Todd Baert <[email protected]>
Kavindu-Dodan
force-pushed
the
feature/statsig
branch
from
acb5397 to
dce0a7e
Compare
Kavindu-Dodan
approved these changes
Feb 2, 2024
|
Merging as this is approved by @xinlili-statsig. Also, looks good in my view and there's good test coverage. |
DBlanchard88
pushed a commit
to DBlanchard88/java-sdk-contrib
that referenced
this pull request
Apr 29, 2024
…ure#641) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readme describes the provider.
@MovieStoreGuy @jasonwzm @xinlili-statsig @toddbaert you are welcome to review.