test(flagd): replace buildsteps with proper annotations. #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
beeme1mr,
Kavindu-Dodan,
thisthat and
toddbaert
aepfli
force-pushed
the
test/remove_redundant_build_steps_with_proper_annotations
branch
from
8448153 to
0566a03
Compare
beeme1mr
approved these changes
Jan 3, 2025
aepfli
force-pushed
the
test/remove_redundant_build_steps_with_proper_annotations
branch
2 times, most recently
from
a37cde1 to
4971ce4
Compare
We are copying our feature definitions into the resource to load them via annoation, but there is an annotation to load a file directly. Hence we do not need this build step, but can utilize the proper annotation. Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
test/remove_redundant_build_steps_with_proper_annotations
branch
from
4971ce4 to
fea783a
Compare
toddbaert
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're copying our feature definitions into the resource to load them via annotation, but there is an annotation that loads a file directly. Hence, we do not need this build step but can utilize the proper annotation.
how to test
Numbers should match