fix: consider default client when loading states #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernd Warmuth <[email protected]>
warber
force-pushed
the
fix/load-state-default-fallback
branch
from
1cb57c5 to
1b76ca0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 86.86% 86.91% +0.05%
==========================================
Files 12 12
Lines 1370 1376 +6
==========================================
+ Hits 1190 1196 +6
Misses 156 156
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bernd Warmuth <[email protected]>
warber
force-pushed
the
fix/load-state-default-fallback
branch
from
a714c3e to
8dc46af
Compare
Signed-off-by: Bernd Warmuth <[email protected]>
Signed-off-by: Bernd Warmuth <[email protected]> Signed-off-by: Bernd Warmuth <[email protected]>
warber
commented
Dec 2, 2024
warber
commented
Dec 2, 2024
warber
commented
Dec 2, 2024
toddbaert
reviewed
Dec 3, 2024
toddbaert
approved these changes
Dec 3, 2024
toddbaert
requested review from
beeme1mr,
hairyhenderson,
bacherfl,
kinyoklion,
Kavindu-Dodan,
aepfli,
craigpastro,
skyerus,
lukas-reining and
DBlanchard88
aepfli
approved these changes
Dec 3, 2024
warber
changed the title
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: warber <[email protected]>
beeme1mr
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
fixes #308 and #310