chore: bump Go to version 1.20 #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
=======================================
Coverage 81.42% 81.42%
=======================================
Files 10 10
Lines 1163 1163
=======================================
Hits 947 947
Misses 196 196
Partials 20 20 ☔ View full report in Codecov by Sentry. |
|
My concern here is the version jump from 1.19 to 1.21. Given SDK is a central piece of OF, I think we should move step-wise (1.19 -> 1.20 -> 1.21) so that adaptation becomes easier where needed. We have a tracking issue for 1.20 already - #253 |
Kavindu-Dodan
force-pushed
the
chore/bump-go
branch
from
a7dec38 to
7e5c426
Compare
Kavindu-Dodan
approved these changes
Feb 23, 2024
|
I have upgraded the PR to bump Go version to 1.20. This allows us to upgrade SDK's go version linearly, avoiding unnecessary impact on downstream users. |
Kavindu-Dodan
changed the title
This was referenced Mar 25, 2024
Kavindu-Dodan
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Pending for TC decision on runtime support & documentation
See discussion - https://github.com/orgs/open-feature/discussions/356
|
After our meeting I'm sure I can say the TC will not block dropping Go 1.19, as long as the go-maintainers support that. Go is a particularly fast-moving runtime. |
toddbaert
approved these changes
Apr 9, 2024
Signed-off-by: odubajDT <[email protected]>
Kavindu-Dodan
force-pushed
the
chore/bump-go
branch
from
7e5c426 to
16aec69
Compare
Kavindu-Dodan
approved these changes
Apr 9, 2024
lukas-reining
approved these changes
Apr 9, 2024
|
Can we extend the readme to include a section on our support policy? |
Signed-off-by: Kavindu Dodanduwa <[email protected]>
I tried to add this with this commit - f854ec4 |
beeme1mr
reviewed
Apr 9, 2024
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
beeme1mr
approved these changes
Apr 9, 2024
gunishmatta
pushed a commit
to gunishmatta/go-sdk
that referenced
this pull request
May 4, 2024
* chore: bump Go to version 1.21 Signed-off-by: odubajDT <[email protected]> * update readme with go version and note Signed-off-by: Kavindu Dodanduwa <[email protected]> * Update README.md Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]> --------- Signed-off-by: odubajDT <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]> Co-authored-by: Kavindu Dodanduwa <[email protected]> Co-authored-by: Kavindu Dodanduwa <[email protected]> Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: gunishmatta <[email protected]>
gunishmatta
pushed a commit
to gunishmatta/go-sdk
that referenced
this pull request
May 4, 2024
* chore: bump Go to version 1.21 Signed-off-by: odubajDT <[email protected]> * update readme with go version and note Signed-off-by: Kavindu Dodanduwa <[email protected]> * Update README.md Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]> --------- Signed-off-by: odubajDT <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]> Co-authored-by: Kavindu Dodanduwa <[email protected]> Co-authored-by: Kavindu Dodanduwa <[email protected]> Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: gunishmatta <[email protected]>
Kavindu-Dodan
added a commit
that referenced
this pull request
May 16, 2024
* added support for domains Signed-off-by: gunishmatta <[email protected]> * added support for domains Signed-off-by: gunishmatta <[email protected]> * chore(deps): update actions/setup-go action to v5 (#237) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <[email protected]> * chore(deps): update cyclonedx/gh-gomod-generate-sbom action to v2 (#179) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <[email protected]> * Update openfeature/client.go Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Gunish Matta <[email protected]> Signed-off-by: gunishmatta <[email protected]> * Update openfeature/client.go Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Gunish Matta <[email protected]> Signed-off-by: gunishmatta <[email protected]> * code review changes Signed-off-by: gunishmatta <[email protected]> * code review changes Signed-off-by: gunishmatta <[email protected]> * code review changes Signed-off-by: gunishmatta <[email protected]> * code review changes Signed-off-by: gunishmatta <[email protected]> * feat: Added domain scoping #261 Please enter the commit message for your chanes. Lines starting Author: Gunish Matta <[email protected]> Signed-off-by: gunishmatta <[email protected]> * chore(main): release 1.11.0 (#254) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <[email protected]> * chore: bump Go to version 1.20 (#255) * chore: bump Go to version 1.21 Signed-off-by: odubajDT <[email protected]> * update readme with go version and note Signed-off-by: Kavindu Dodanduwa <[email protected]> * Update README.md Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]> --------- Signed-off-by: odubajDT <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]> Co-authored-by: Kavindu Dodanduwa <[email protected]> Co-authored-by: Kavindu Dodanduwa <[email protected]> Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: gunishmatta <[email protected]> * code review changes Signed-off-by: gunishmatta <[email protected]> * code review changes Signed-off-by: gunishmatta <[email protected]> * code review changes Signed-off-by: gunishmatta <[email protected]> * code review changes Signed-off-by: gunishmatta <[email protected]> * fix(deps): update module github.com/cucumber/godog to v0.14.1 (#267) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <[email protected]> * chore(deps): update goreleaser/goreleaser-action action to v5 (#219) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <[email protected]> * chore(deps): update codecov/codecov-action action to v4 (#250) * chore(deps): update codecov/codecov-action action to v4 * add codecov upload token Signed-off-by: Michael Beemer <[email protected]> --------- Signed-off-by: Michael Beemer <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: gunishmatta <[email protected]> * fix(deps): update module golang.org/x/exp to v0.0.0-20240416160154-fe59bbe5cc7f (#269) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <[email protected]> * chore(deps): update codecov/codecov-action action to v4.3.1 (#270) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <[email protected]> * Revert "code review changes" This reverts commit 3472ee8. Signed-off-by: gunishmatta <[email protected]> * code review changes Signed-off-by: gunishmatta <[email protected]> --------- Signed-off-by: gunishmatta <[email protected]> Signed-off-by: Gunish Matta <[email protected]> Signed-off-by: odubajDT <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]> Signed-off-by: Michael Beemer <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Beemer <[email protected]> Co-authored-by: Dave Henderson <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: odubajDT <[email protected]> Co-authored-by: Kavindu Dodanduwa <[email protected]> Co-authored-by: Kavindu Dodanduwa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253