Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement in-process-flagd provider #327

Merged
merged 11 commits into from
Sep 13, 2023

Conversation

bacherfl
Copy link
Contributor

@bacherfl bacherfl commented Sep 6, 2023

This PR adds the in-process flagd provider, following the flagd specification

@bacherfl bacherfl force-pushed the feat/in-process-flagd-provider branch from 0893958 to f4be496 Compare September 6, 2023 10:53
@bacherfl bacherfl marked this pull request as ready for review September 6, 2023 12:51
@bacherfl bacherfl requested a review from a team as a code owner September 6, 2023 12:51
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :)

@toddbaert toddbaert requested a review from mowies September 7, 2023 18:51
@Kavindu-Dodan
Copy link
Contributor

Kavindu-Dodan commented Sep 7, 2023

@bacherfl I think you forgot to include the go.mod file.

Given this is a new module, we need to configure release please configuration 1 and set manifest 2 with initial release version.

Regarding module name 🤔 shall we prefix this with flagd (flagd-in-memory). This should help the folder ordering in provider directory 3 and give the idea that this is a flagd module.

Also, I faced a weird depdency issue with flagd. This was due to OTel dependency issue. Please use the latest flagd core version - https://github.com/open-feature/flagd/releases/tag/core%2Fv0.6.5

Footnotes

  1. https://github.com/open-feature/go-sdk-contrib/blob/main/release-please-config.json

  2. https://github.com/open-feature/go-sdk-contrib/blob/main/.release-please-manifest.json

  3. https://github.com/open-feature/go-sdk-contrib/tree/main/providers

providers/in-process-flagd/README.md Outdated Show resolved Hide resolved
providers/in-process-flagd/internal/logger/logger.go Outdated Show resolved Hide resolved
providers/in-process-flagd/provider.go Outdated Show resolved Hide resolved
providers/in-process-flagd/provider.go Outdated Show resolved Hide resolved
@bacherfl bacherfl force-pushed the feat/in-process-flagd-provider branch from b7fb0b7 to ebdeb44 Compare September 11, 2023 13:35
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl bacherfl force-pushed the feat/in-process-flagd-provider branch from b2b0818 to 8cdadc6 Compare September 12, 2023 08:36
Signed-off-by: Florian Bacher <[email protected]>
@toddbaert toddbaert self-requested a review September 12, 2023 15:53
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending comment here. I'll add the test suite once this is merged and then we can consider what we'd want before a final release (we may want spec 0.7.0 implemented first).

@toddbaert toddbaert merged commit f9a68b1 into open-feature:main Sep 13, 2023
liran2000 pushed a commit to liran2000/go-sdk-contrib that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants