-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement in-process-flagd provider #327
feat: implement in-process-flagd provider #327
Conversation
0893958
to
f4be496
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! :)
@bacherfl I think you forgot to include the Given this is a new module, we need to configure release please configuration 1 and set manifest 2 with initial release version. Regarding module name 🤔 shall we prefix this with Also, I faced a weird depdency issue with flagd. This was due to OTel dependency issue. Please use the latest flagd core version - https://github.com/open-feature/flagd/releases/tag/core%2Fv0.6.5 Footnotes |
b7fb0b7
to
ebdeb44
Compare
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
b2b0818
to
8cdadc6
Compare
Signed-off-by: Florian Bacher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending comment here. I'll add the test suite once this is merged and then we can consider what we'd want before a final release (we may want spec 0.7.0
implemented first).
Signed-off-by: Florian Bacher <[email protected]> Signed-off-by: liran2000 <[email protected]>
This PR adds the in-process flagd provider, following the flagd specification