-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: improve gherkin files #161
base: main
Are you sure you want to change the base?
Conversation
9fbb85d
to
72acea4
Compare
relates to #166 |
8c3de77
to
6f5055d
Compare
Signed-off-by: Simon Schrottner <[email protected]>
49ba22e
to
dc3a944
Compare
Signed-off-by: Simon Schrottner <[email protected]>
dc3a944
to
796c0e8
Compare
6804205
to
e91f61f
Compare
open-feature/java-sdk-contrib#1115 and open-feature/python-sdk-contrib#121 and open-feature/js-sdk-contrib#1129 Those need to have a little bit more work still, as they're not 100% feature complete, but show the process in general |
e91f61f
to
2e6d291
Compare
@toddbaert @beeme1mr I would love to move forward with this. I have implemented reference implementations within Java and Python (also using tags to exclude features), which work great (except for Python 3.8, which is a little sad, but I can't fix the tooling). (teaser: I also have a socket path implementation for Python with this test suite ready) Let me know what you think :) |
1bd95d3
to
169e533
Compare
Signed-off-by: Simon Schrottner <[email protected]>
169e533
to
53bfd58
Compare
I looked at our Gherkin files, and I feel we can optimize them slightly. They're sometimes hard to use.
When
intoGiven