feat: Introduce service definition for GRPC sync contract #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
|
We should update the docs in |
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Thank you, I improved the documentation. |
3 tasks
skyerus
reviewed
Feb 6, 2023
toddbaert
reviewed
Feb 6, 2023
toddbaert
reviewed
Feb 6, 2023
Co-authored-by: Skye Gill <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Skye Gill <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Skye Gill <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Skye Gill <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Skye Gill <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Skye Gill <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Skye Gill <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Skye Gill <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Skye Gill <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Skye Gill <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
Kavindu-Dodan
requested review from
beeme1mr,
james-milligan and
toddbaert
and removed request for
beeme1mr,
james-milligan and
toddbaert
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Kavindu-Dodan
force-pushed
the
feature/sync-service
branch
from
4bc2baa to
5ba1f9c
Compare
toddbaert
reviewed
Feb 6, 2023
Signed-off-by: Kavindu Dodanduwa <[email protected]>
toddbaert
reviewed
Feb 6, 2023
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
skyerus
reviewed
Feb 7, 2023
Co-authored-by: Skye Gill <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Skye Gill <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
beeme1mr
pushed a commit
to open-feature/flagd
that referenced
this pull request
Feb 7, 2023
@Kavindu-Dodan has contributed multiple significant changes and proposals to flagd: - multiple refactors: #291, #307 - ci/security improvements: #338, #337 - architectural proposals (some of which got some attention from outside parties!): open-feature/ofep#45, open-feature/flagd-schemas#78, #249 (comment) - load testing: #225 - documentation improvements For these reasons, I believe he should be made a CODEOWNER in this repository. NOTE: before this is merged, @Kavindu-Dodan should be added with at least `maintainer` permissions to the repo. Signed-off-by: Todd Baert <[email protected]>
Kavindu-Dodan
requested review from
james-milligan
and removed request for
beeme1mr
james-milligan
approved these changes
Feb 7, 2023
skyerus
approved these changes
Feb 7, 2023
toddbaert
approved these changes
Feb 7, 2023
toddbaert
approved these changes
Feb 7, 2023
Merged
toddbaert
pushed a commit
that referenced
this pull request
Feb 7, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>protobuf: 0.2.9</summary> ## [0.2.9](protobuf-v0.2.8...protobuf-v0.2.9) (2023-02-07) ### Features * Introduce service definition for GRPC sync contract ([#78](#78)) ([2ba81e3](2ba81e3)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Is related to open-feature/ofep#45 & open-feature/flagd#297
Introduce the service contract of grpc sync.
Consider checking my personal buf repository - https://buf.build/kavindudodan/flagd for a preview