Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to show/hide ungraded assignment in progress page #14

Conversation

navinkarkera
Copy link
Member

@navinkarkera navinkarkera commented May 10, 2024

Cherry picked from openedx#1380

Private-ref: BB-8824

@navinkarkera navinkarkera requested a review from Agrendalath May 10, 2024 09:56
@Agrendalath
Copy link
Member

@navinkarkera, could you please rebase this PR to include the latest changes from the upstream one?

test: add tests for show ungraded toggle

feat: update score label in progress page based on grading

refactor: update score label text and add tooltip

refactor: move label tooltip near header as normal text

refactor: update problem score label Graded scores
(cherry picked from commit bd4715b)
@navinkarkera navinkarkera force-pushed the navin/palm-backport/show-ungraded-progress branch from 1d555d7 to 52f930f Compare July 30, 2024 02:26
@navinkarkera
Copy link
Member Author

@Agrendalath Done. Let me know when we can move the upstream PR to ready state.

Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in openedx#1380 (review).

@Agrendalath
Copy link
Member

@navinkarkera, can we also backport this to our Redwood fork?

@Agrendalath Agrendalath merged commit 8b6e1b0 into opencraft-release/palm.1 Aug 8, 2024
2 of 3 checks passed
@Agrendalath Agrendalath deleted the navin/palm-backport/show-ungraded-progress branch August 8, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants