fix: dropdown menus show over the sidebar #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the sidebar to the same z-level as the header, because layout dictates that it sits above it anyway. So could move the dropdown menus up to above the sidebar.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chris/FAL-3873-expand-issue #74 +/- ##
==============================================================
Coverage ? 93.16%
==============================================================
Files ? 1054
Lines ? 20467
Branches ? 4285
==============================================================
Hits ? 19068
Misses ? 1339
Partials ? 60 ☔ View full report in Codecov by Sentry. |
ChrisChV
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Looks good 👍
- I tested this: I followed the testing instruction
- I read through the code and considered the security, stability and performance implications of the changes.
- I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
- Includes tests for bugfixes and/or features added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the sidebar to the same z-index as the header, because layout dictates that the sidebar sits above the header anyway. So could move the dropdown menus up to above the sidebar without using a silly z-index.
Expand button is still ok:
Builds on openedx#1438
Testing instructions