Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the saving pop-up to appear #73

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

farhaanbukhsh
Copy link
Member

@farhaanbukhsh farhaanbukhsh commented Oct 21, 2024

When the user tries to add more than 5 grades then the save pop that appears near the footer doesn't appear.

JIRA tickets: Private ref: BB-9232

Testing instructions:

  1. Set the theming as mentioned in Fixes the grade removing issues in studio. #72
  2. Once that is done go to the grade page and see if you have more than 5 grades available.
  3. If not you need to change settings under edx-platform
diff --git a/cms/envs/common.py b/cms/envs/common.py
index 7918624841..c4bea76847 100644
--- a/cms/envs/common.py
+++ b/cms/envs/common.py
@@ -2442,7 +2442,7 @@ POLICY_CHANGE_TASK_RATE_LIMIT = '900/h'
 # .. setting_warning: The DEFAULT_GRADE_DESIGNATIONS list must have more than one designation,
 #     or else ['A', 'B', 'C', 'D'] will be used as the default grade designations. Also, only the first
 #     11 grade designations are used by the UI, so it's advisable to restrict the list to 11 items.
-DEFAULT_GRADE_DESIGNATIONS = ['A', 'B', 'C', 'D']
+DEFAULT_GRADE_DESIGNATIONS = ['A-', 'B+', 'B-', 'C+', 'C-', 'D+']
 
  1. This should reload the LMS and if doesn't then you need to restart LMS by tutor dev restart lms
  2. Hard refresh the page and try adding the grade and save the grades. More than 4 possibly.
  3. Now try adding the grade again and you should see that the save grade box will not appear.
  4. Now change to farhaan-grading-pop and restart the course-authoring app tutor dev restart course-authoring
  5. Try the above steps again and you should see it working.

@farhaanbukhsh farhaanbukhsh force-pushed the farhaan/fix-grading-pop branch from 064375f to e7c5b7f Compare October 22, 2024 07:47
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.64%. Comparing base (acbd7fa) to head (e1ef191).
Report is 11 commits behind head on asu-moe/redwood-css.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           asu-moe/redwood-css      #73      +/-   ##
=======================================================
+ Coverage                92.54%   92.64%   +0.09%     
=======================================================
  Files                      706      706              
  Lines                    12515    12545      +30     
  Branches                  2728     2704      -24     
=======================================================
+ Hits                     11582    11622      +40     
+ Misses                     898      888      -10     
  Partials                    35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tecoholic tecoholic closed this Oct 23, 2024
@tecoholic tecoholic reopened this Oct 23, 2024
Copy link
Member

@tecoholic tecoholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhaanbukhsh 👍

  • I tested this: Verified that the save button issue is fixed as described.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Note: Codecov is complaining about missing coverage. Also should we have an upstream PR for this?

@farhaanbukhsh
Copy link
Member Author

farhaanbukhsh commented Oct 24, 2024

@tecoholic it is related to openedx#1227 so I will just merge this with @xitij2000's branch

@farhaanbukhsh farhaanbukhsh force-pushed the farhaan/fix-grading-pop branch from e7c5b7f to 0262f83 Compare October 24, 2024 13:49
Moves the array updation statement and introduces two ways of updating
the grading statement.

Signed-off-by: Farhaan Bukhsh <[email protected]>
@farhaanbukhsh farhaanbukhsh force-pushed the farhaan/fix-grading-pop branch from b57a044 to e1ef191 Compare October 24, 2024 14:03
@farhaanbukhsh farhaanbukhsh merged commit bb553c5 into asu-moe/redwood-css Oct 25, 2024
5 checks passed
@farhaanbukhsh farhaanbukhsh deleted the farhaan/fix-grading-pop branch October 25, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants