feat(cli): amtinfo command add amt ipaddr and osipaddr

[tongsean9807]

Add os ipaddress to amtinfo command.
amtinfo command now show amt ipaddrss and os ipaddress.
os ipadress select by mapping to mac address from amt.

Resolves: #467

[tongsean9807]

Output:

[rsdmike]

I like this being added. I left a few nit picks, but most importantly is to remove the uint32 conversion and move it out of the PTHI package and into the internal package, likely in the internal/local/info.go file.

[codecov]

Codecov Report

Attention: Patch coverage is 71.69811% with 15 lines in your changes missing coverage. Please review.

Project coverage is 71.29%. Comparing base (650935d) to head (93ba577).
Report is 250 commits behind head on main.

Files	Patch %	Lines
internal/local/info.go	71.15%	10 Missing and 5 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #560       +/-   ##
===========================================
- Coverage   83.21%   71.29%   -11.92%     
===========================================
  Files          32       41        +9     
  Lines        4265     4132      -133     
===========================================
- Hits         3549     2946      -603     
- Misses        576      919      +343     
- Partials      140      267      +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tongsean9807]

Hi,

I have move the GetOSIPAddress() to internal/local/info.go
Let me know what other changes is needed.

I will squash them after fixing all the changes.

Thank you

[rsdmike]

@tongsean9807 looks good to me. You think you can muster up a unit test or two? Additionally, the commit message should really be feat: since its a new capability added to the cli.

[tongsean9807]

Hi,

I have changed the space to tab, which causes the misalignment when viewing in github.
I have added the unittest but I am unable to overwrite the net.interface.
Let me know if there are better ways to improve the unittest.

Thank you

[rsdmike]

Hi @tongsean9807 , Thank you for adding the unit test! I should have sent this to you, we have a NetEnumerator

rpc-go/internal/flags/flags.go

Lines 30 to 31 in bacb0eb

	type NetEnumerator struct {
	Interfaces func() ([]net.Interface, error)

that you can use to abstract the net.Interfaces calls.

Can take a look at

rpc-go/internal/flags/flags_test.go

Line 115 in bacb0eb

var testNetEnumerator = NetEnumerator{

for an example of how it is used in tests.

For the code that uses the NetEnumerator check out:

rpc-go/internal/flags/maintenance.go

Line 196 in bacb0eb

ifaces, err := f.netEnumerator.Interfaces()

.

[tongsean9807]

Hi,

I have add positive and negative unit test.
And use the net enumerator from flags package.

Thank you for the pointing out the net enumerator.

Regards,
Sean

[tongsean9807]

Hi @rsdmike,

I hope you're doing well. I want to follow up on this PR.
I have made the changes.
Have you had a chance to review it?

Thank you

[rsdmike]

Hi @rsdmike,

I hope you're doing well. I want to follow up on this PR. I have made the changes. Have you had a chance to review it?

Thank you

Thanks for following up, looks good to me! We'll get it merged.