Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: config file comments #215

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

tim-shockley
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f60aed6) 82.36% compared to head (1090fdb) 82.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   82.36%   82.36%           
=======================================
  Files          24       24           
  Lines        3397     3397           
=======================================
  Hits         2798     2798           
  Misses        478      478           
  Partials      121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tim-shockley tim-shockley force-pushed the fix-example-config-file branch from 9fa8075 to c80a4ae Compare September 11, 2023 23:53
Copy link
Member

@rsdmike rsdmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, however the commit message should be a docs or refactor, no actual fix to the code is happening here,

@tim-shockley tim-shockley force-pushed the fix-example-config-file branch from b7ce395 to 1090fdb Compare September 15, 2023 16:53
@tim-shockley tim-shockley changed the title fix: config file comments docs: config file comments Sep 15, 2023
@madhavilosetty-intel madhavilosetty-intel merged commit 7250d9e into main Sep 15, 2023
14 checks passed
@madhavilosetty-intel madhavilosetty-intel deleted the fix-example-config-file branch September 15, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants