Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(utils): creates type for return codes and make variable names consistent #212

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

Craig-Spencer-12
Copy link
Contributor

@Craig-Spencer-12 Craig-Spencer-12 commented Sep 7, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 95.13% and no project coverage change.

Comparison is base (ae42b5b) 81.94% compared to head (186b8ca) 81.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files          24       24           
  Lines        3340     3340           
=======================================
  Hits         2737     2737           
  Misses        485      485           
  Partials      118      118           
Files Changed Coverage Δ
internal/rps/rps.go 72.15% <66.66%> (ø)
internal/local/lps.go 83.33% <75.00%> (ø)
internal/flags/configure.go 88.15% <80.48%> (ø)
internal/amt/commands.go 73.51% <100.00%> (ø)
internal/flags/activate.go 100.00% <100.00%> (ø)
internal/flags/deactivate.go 100.00% <100.00%> (ø)
internal/flags/flags.go 100.00% <100.00%> (ø)
internal/flags/info.go 100.00% <100.00%> (ø)
internal/flags/maintenance.go 84.14% <100.00%> (ø)
internal/flags/version.go 50.00% <100.00%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Craig-Spencer-12 Craig-Spencer-12 changed the title refactor(returnCodes): creates type for return codes and make variable names consistent refactor(utils): creates type for return codes and make variable names consistent Sep 7, 2023
Copy link

@tim-shockley tim-shockley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tim-shockley tim-shockley merged commit d0ddd44 into main Sep 11, 2023
13 checks passed
@tim-shockley tim-shockley deleted the returnCodeType branch September 11, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants