Skip to content

refactor: add validation to apf #476

refactor: add validation to apf

refactor: add validation to apf #476

Triggered via pull request December 16, 2024 20:36
Status Failure
Total duration 1m 38s
Artifacts 8

ci.yml

on: pull_request
runner / formatting
23s
runner / formatting
runner / golangci-lint
33s
runner / golangci-lint
runner / yamllint
18s
runner / yamllint
runner / dotenv-linter
10s
runner / dotenv-linter
Matrix: runner / build and tests
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 14 warnings
runner / golangci-lint: pkg/apf/vaildator.go#L18
[golangci] reported by reviewdog 🐶 return with no blank line before (nlreturn) Raw Output: pkg/apf/vaildator.go:18:2: return with no blank line before (nlreturn) return len(data) >= 5+serviceLen ^
runner / golangci-lint: pkg/apf/vaildator.go#L39
[golangci] reported by reviewdog 🐶 return with no blank line before (nlreturn) Raw Output: pkg/apf/vaildator.go:39:2: return with no blank line before (nlreturn) return false ^
runner / golangci-lint: pkg/apf/vaildator.go#L37
[golangci] reported by reviewdog 🐶 return with no blank line before (nlreturn) Raw Output: pkg/apf/vaildator.go:37:3: return with no blank line before (nlreturn) return len(data) >= 14+globalReqLen+addrLen ^
runner / golangci-lint: pkg/apf/processor.go#L25
[golangci] reported by reviewdog 🐶 if statements should only be cuddled with assignments (wsl) Raw Output: pkg/apf/processor.go:25:3: if statements should only be cuddled with assignments (wsl) if ValidateGlobalRequest(data) { ^
runner / golangci-lint: pkg/apf/processor.go#L34
[golangci] reported by reviewdog 🐶 if statements should only be cuddled with assignments (wsl) Raw Output: pkg/apf/processor.go:34:3: if statements should only be cuddled with assignments (wsl) if ValidateServiceRequest(data) { ^
runner / golangci-lint: pkg/apf/processor.go#L39
[golangci] reported by reviewdog 🐶 if statements should only be cuddled with assignments (wsl) Raw Output: pkg/apf/processor.go:39:3: if statements should only be cuddled with assignments (wsl) if ValidateChannelOpenConfirmation(data) { ^
runner / golangci-lint: pkg/apf/vaildator.go#L36
[golangci] reported by reviewdog 🐶 assignments should only be cuddled with other assignments (wsl) Raw Output: pkg/apf/vaildator.go:36:3: assignments should only be cuddled with other assignments (wsl) addrLen := int(binary.BigEndian.Uint32(data[6+globalReqLen : 10+globalReqLen])) ^
runner / golangci-lint: pkg/apf/vaildator.go#L17
[golangci] reported by reviewdog 🐶 assignments should only be cuddled with other assignments (wsl) Raw Output: pkg/apf/vaildator.go:17:2: assignments should only be cuddled with other assignments (wsl) serviceLen := int(binary.BigEndian.Uint32(data[1:5])) ^
runner / golangci-lint: pkg/apf/vaildator.go#L26
[golangci] reported by reviewdog 🐶 assignments should only be cuddled with other assignments (wsl) Raw Output: pkg/apf/vaildator.go:26:2: assignments should only be cuddled with other assignments (wsl) globalReqLen := int(binary.BigEndian.Uint32(data[1:5])) ^
runner / golangci-lint
reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
runner / dotenv-linter
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
runner / yamllint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
runner / yamllint
Input 'fail_on_error' has been deprecated with message: Deprecated, use `fail_level` instead.
runner / formatting
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
runner / golangci-lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
runner / golangci-lint
Input 'fail_on_error' has been deprecated with message: Deprecated, use `fail_level` instead.
runner / build and tests (1.22.x, ubuntu-22.04)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
runner / build and tests (1.22.x, windows-2022)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
runner / build and tests (1.22.x, windows-2019)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
runner / build and tests (1.22.x, ubuntu-20.04)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
runner / build and tests (1.23.x, ubuntu-22.04)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
runner / build and tests (1.23.x, ubuntu-20.04)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
runner / build and tests (1.23.x, windows-2019)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
runner / build and tests (1.23.x, windows-2022)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Artifacts

Produced during runtime
Name Size
JUnit Results ubuntu-20.04-1.22.x-1
12.2 KB
JUnit Results ubuntu-20.04-1.23.x-1
12.5 KB
JUnit Results ubuntu-22.04-1.22.x-1
12.2 KB
JUnit Results ubuntu-22.04-1.23.x-1
12.5 KB
JUnit Results windows-2019-1.22.x-1
12.1 KB
JUnit Results windows-2019-1.23.x-1
12.5 KB
JUnit Results windows-2022-1.22.x-1
12.2 KB
JUnit Results windows-2022-1.23.x-1
12.5 KB