Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed requirements for images in OPDS 2.0 #80

Merged
merged 2 commits into from
May 7, 2024

Conversation

HadrienGardeur
Copy link
Member

@HadrienGardeur HadrienGardeur commented Apr 17, 2024

Based on @llemeurfr initial comment on #52 :

  • Lowered the requirement for images in publication to a SHOULD
  • Dropped requirement from the JSON Schema
  • Added AVIF support in spec and JSON Schema

Lowered the requirement for images in publication to a SHOULD
Dropped requirement from the JSON Schema
AVIF is now supported across all major platforms and has the best size/quality ratio
@HadrienGardeur HadrienGardeur changed the title Changed requirement for images in OPDS 2.0 Changed requirements for images in OPDS 2.0 Apr 17, 2024
@HadrienGardeur HadrienGardeur self-assigned this Apr 18, 2024
@HadrienGardeur
Copy link
Member Author

While the initial issue opened by @llemeurfr didn't mention AVIF, I used this opportunity to add it to the list of supported formats.

AVIF is now widely supported across browsers and it's a strong contender for replacing JPEG as the default format for covers in OPDS now.
WebP is another potential addition to this list, but I'm not sure that it makes a whole lot of sense now that AVIF is well supported.

@HadrienGardeur HadrienGardeur merged commit 0e58f3e into main May 7, 2024
@HadrienGardeur HadrienGardeur deleted the image-requirement branch May 7, 2024 13:50
@barmintor
Copy link
Contributor

For what it is worth: I think the spec would benefit from being silent about required image formats for thumbnails:

  • The ability to display an image of a given format is an out-of-band client concern
  • The images property/collection is not required for correctness
  • The spec includes MIME information for the links for a client to decide whether it can make use of the link
  • There's no difference for the reader between there not being a supported image and there not being images at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants