Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBW-8033] playsinline attribute now added in desktop as well #355

Merged
merged 3 commits into from
May 17, 2019
Merged

[PBW-8033] playsinline attribute now added in desktop as well #355

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2edd02b
fix/PBW-8033 playsinline attribute now shown in any browser (as bitmo…
May 8, 2019
8c1972d
Merge branch 'master' of https://github.com/ooyala/html5-video-plugin…
May 13, 2019
6dfe01a
fix/PBW-8033 tests fixed
May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/main/js/main_html5.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,14 +119,10 @@ require('../../../html5-common/js/utils/environment.js');
// http://developer.apple.com/library/safari/#documentation/AudioVideo/Conceptual/AirPlayGuide/OptingInorOutofAirPlay/OptingInorOutofAirPlay.html
//
video.attr('x-webkit-airplay', 'allow');

// enable inline playback for mobile
if (pluginParams['iosPlayMode'] === 'inline') {
const iosVersion = 10;
if (OO.iosMajorVersion >= iosVersion) {
video.attr('playsinline', '');
}
}
}
// enable inline playback for mobile
if (pluginParams && pluginParams['iosPlayMode'] === 'inline') {
video.attr('playsinline', '');
}

let element = new OoyalaVideoWrapper(domId, video[0], playerId);
Expand Down