Inject webpack into html5_video_plugin repo #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zelibobla
approved these changes
Dec 14, 2018
nzaitcev
approved these changes
Dec 21, 2018
ooyala-amohnatkin
suggested changes
Dec 21, 2018
package.json
Outdated
| @@ -10,7 +10,9 @@ | |||
| }, | |||
| "scripts": { | |||
| "build": "gulp", | |||
| "test": "jest" | |||
| "test": "jest", | |||
| "start": "webpack --mode development", | |||
There was a problem hiding this comment.
seems more like build task
There was a problem hiding this comment.
Let's make it consistent with html5-skin repo.
Now build task can't be modified, so we can call it build:future
"build:future": "webpack --mode development",
"build-prod": "webpack --mode production",
"start": "webpack-dev-server"
There was a problem hiding this comment.
Thanks for your comment, I'lI add those changes. Previously I was thinking about webpack-dev-server and I didn't add it because gulp doesn't do it in this repo.
webpack.config.js
Outdated
| }) | ||
| ], | ||
| devtool: 'sourcemap', | ||
| watch: true |
There was a problem hiding this comment.
let's use webpack-dev-server for watching
ooyala-amohnatkin
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.corp.ooyala.com/browse/PLAYER-4906