Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update constants for progressive audio types #342

Merged
merged 2 commits into from
Nov 13, 2018
Merged

update constants for progressive audio types #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dedfe6f
update constants for progressive audio types
dallen42 Nov 13, 2018
1a825c8
repair a unit test
dallen42 Nov 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion html5-common
Open in desktop
Submodule html5-common updated 1 files
+8 −8 js/utils/constants.js
4 changes: 2 additions & 2 deletions src/main/js/main_html5.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ import CONSTANTS from "./constants/constants";
}

if (!!videoElement.canPlayType("audio/ogg")) {
list.push(OO.VIDEO.ENCODING.OGG);
list.push(OO.VIDEO.ENCODING.AUDIO_OGG);
}

if (!!videoElement.canPlayType("audio/x-m4a")) {
list.push(OO.VIDEO.ENCODING.M4A);
list.push(OO.VIDEO.ENCODING.AUDIO_M4A);
}

if (!!videoElement.canPlayType("video/webm")) {
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/main_html5/factory-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe('main_html5 factory tests', function () {

it('should provide a list of supported encodings', function(){
// This is controlled by document.createElement("video").canPlayType(type);
expect(pluginFactory.encodings).to.eql([OO.VIDEO.ENCODING.MP4, OO.VIDEO.ENCODING.OGG, OO.VIDEO.ENCODING.M4A, OO.VIDEO.ENCODING.WEBM, OO.VIDEO.ENCODING.HLS, OO.VIDEO.ENCODING.AKAMAI_HD2_VOD_HLS, OO.VIDEO.ENCODING.AKAMAI_HD2_HLS, OO.VIDEO.ENCODING.AUDIO_HLS]);
expect(pluginFactory.encodings).to.eql([OO.VIDEO.ENCODING.MP4, OO.VIDEO.ENCODING.AUDIO_OGG, OO.VIDEO.ENCODING.AUDIO_M4A, OO.VIDEO.ENCODING.WEBM, OO.VIDEO.ENCODING.HLS, OO.VIDEO.ENCODING.AKAMAI_HD2_VOD_HLS, OO.VIDEO.ENCODING.AKAMAI_HD2_HLS, OO.VIDEO.ENCODING.AUDIO_HLS]);
});

it('should provide a list of supported features', function(){
Expand Down