[PLAYER-4385] Updating html5-common #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpfranco
requested review from
zelibobla,
aldigun,
dallen42,
aeng7 and
KseniiaSokolovaEpam
|
LGTM |
|
A bit confused on why do we have this PR if the changes are done only for submodule not for the current repo? Shouldn't we just update the html5_common and a link from here? |
|
@zelibobla this is because of the way that html5-common currently works. Whenever we do a change we need to update the submodule of every project to the latest commit in order to ensure that the same version is used regardless of which plugin is included. This is significant tech debt that needs to be addressed, but it's outside of the scope of this task. |
zelibobla
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.