[PLAYER-4422] changes to seek to previous position in dvr window on failover for live #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpfranco
reviewed
Sep 25, 2018
src/main/js/main_html5.js
Outdated
| @@ -1371,7 +1392,9 @@ import CONSTANTS from "./constants/constants"; | |||
| * @param {object} event The event from the video | |||
| */ | |||
| var raiseDurationChange = _.bind(function(event) { | |||
| raisePlayhead(this.controller.EVENTS.DURATION_CHANGE, event); | |||
| if (!isLive || isDvrAvailable()) { | |||
There was a problem hiding this comment.
Are there any side-effects to omitting this notification for Live streams that don't have DVR?
There was a problem hiding this comment.
@jpfranco sorry I forgot to revert this. Was trying to avoid another minor issue with the playhead flashing to the start of the dvr window if failover happens on the live edge. I think this may introduce other consequences though as you suggest
|
LGTM other than @jpfranco 's comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping unit tests to get this into tonight's build for QA testing, will add tests later