[PLAYER-4216] (PR 3 of 3) MainHtml5 closed captions refactor #333
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,12 @@ | ||
| { | ||
| "presets": [ | ||
| [ | ||
| "@babel/preset-env", { | ||
| "targets": { | ||
| "ie": 11 | ||
| }, | ||
| "useBuiltIns": "usage" | ||
| } | ||
| ] | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
|
|
||
| const CONSTANTS = { | ||
|
There was a problem hiding this comment. Deliberately left this out of html5-common since only MainHtml5 should be concerned with these values |
||
|
|
||
| ID_PREFIX: { | ||
| INTERNAL: 'CC', | ||
| EXTERNAL: 'VTT', | ||
| }, | ||
|
|
||
| TEXT_TRACK: { | ||
| KIND: { | ||
| SUBTITLES: 'subtitles', | ||
| CAPTIONS: 'captions', | ||
| DESCRIPTIONS: 'descriptions', | ||
| CHAPTERS: 'chapters', | ||
| METADATA: 'metadata', | ||
| } | ||
| }, | ||
|
|
||
| }; | ||
|
|
||
| export default CONSTANTS; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default Babel will transpile es6 syntax but it will not automatically add polyfills for APIs such as
Array.prototype.filterorObject.assign. Eventually we should look for a way to load all polyfills in the core so that they are available for all plugins without including them on each script