Skip to content

Commit

Permalink
Merge pull request #347 from ooyala/chore/PLAYER-4915
Browse files Browse the repository at this point in the history
Apply Eslint into html5_video_plugin repo
  • Loading branch information
zelibobla authored Dec 27, 2018
2 parents 7022fb7 + 148d034 commit d25b081
Show file tree
Hide file tree
Showing 13 changed files with 5,057 additions and 3,981 deletions.
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
src/*/lib/**
60 changes: 60 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
{
"extends": "standard",
"globals": {
"_": false,
"$": false,
"OO": false,
"YT": false
},
"plugins": [
"require-jsdoc-except"
],
"rules": {
"space-before-function-paren": ["error", "never"],
"comma-dangle": ["error", "always-multiline"],
"default-case": ["error"],
"id-length": ["error", { "exceptions": ["_", "$"] }],
"max-len": [
"error", 110,
{
"ignoreComments": true,
"ignorePattern": "if \\(\/\\(\\w*|\\)\/",
"ignoreUrls": true,
"ignoreRegExpLiterals": true
}
],
"no-continue": ["warn"],
"no-magic-numbers": ["error", { "ignore": [-1, 0, 0.01, 1, 2, 100] }],
"no-param-reassign": ["error"],
"no-var": ["error"],
"one-var-declaration-per-line": ["error"],
"require-jsdoc-except/require-jsdoc": [
"error",
{
"require": {
"MethodDefinition": true,
"ClassDeclaration": true,
"FunctionDeclaration": true
},
"ignore": [
"constructor",
"componentWillMount",
"componentDidMount",
"componentWillUnmount",
"componentWillReceiveProps",
"render"
]
}
],
"semi": ["error", "always"],
"valid-jsdoc": [
"error",
{
"prefer": {
"return": "returns"
},
"requireReturn": false
}
]
}
}
4 changes: 2 additions & 2 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ var gulp = require('gulp'),
browserify = require('browserify'),
source = require('vinyl-source-stream'),
buffer = require('vinyl-buffer'),
uglify = require('gulp-uglify'),
uglify = require('gulp-uglify-es').default,
shell = require('gulp-shell'),
rename = require('gulp-rename'),
exec = require('child_process').exec;
Expand Down Expand Up @@ -76,7 +76,7 @@ gulp.task('init_module', function(callback) {
gulp.task('build_flash_osmf', function(callback) {
exec("ant -buildfile build_flash.xml -Dbuild=build/classes wrapper", function(err) {
exec("ant -buildfile build_flash.xml -Dbuild=build/classes build-CC-osmf", function(err) {
exec("ant -buildfile build_flash.xml -Dbuild=build/classes build-osmf", function(err) {
exec("ant -buildfile build_flash.xml -Dbuild=build/classes build-osmf", function(err) {
if (err) console.log("Error occured in building osmf plugin : " + err);
else {osmf_fn();}
exec("ant -buildfile build_flash.xml -Dbuild=build/classes clean-osmf", function(err) {
Expand Down
Loading

0 comments on commit d25b081

Please sign in to comment.