Fix migrations and some sequel things #457
Conversation
mrbrdo
commented
Jun 26, 2013
mrbrdo
commented
- fixed migrations to be compatible with databases other than MySQL (more or less just removed backticks and used some Sequel migration methods in place where you used raw SQL)
- fixed to use Sequel.desc and asc instead of Symbol#desc as it was deprecated
| @@ -2,8 +2,6 @@ | |||
|
|
|||
| Sequel.migration do | |||
| up do | |||
| # Sequel has no database-independent way of dropping a foreign key constraint. | |||
| run "ALTER TABLE `commits` DROP FOREIGN KEY `commits_ibfk_2`" | |||
| alter_table(:commits) do | |||
| drop_column :user_id | |||
There was a problem hiding this comment.
This should be drop_foreign_key :user_id which will also drop the column. MySQL does not automatically drop foreign keys. Also in the down action it should be add_foreign_key :user_id, :users, :key => :id according to Sequel docs:
For foreign key columns, the column in the associated table that this column references. Unnecessary if this column references the primary key of the associated table, except if you are using MySQL.
There was a problem hiding this comment.
I moved away from Barkeep, but you are welcome to pick this up.
There was a problem hiding this comment.
What alternative did you choose in the end? The barkeep repo seems pretty much unmaintained right now.
There was a problem hiding this comment.
naforo.com (disclaimer I am the author)
There was a problem hiding this comment.
Looks great and a git-hook based tool should work fine with our git repos which are coupled to our Redmine which handles auth/auth. I've dropped you an invite request from my company email.
OK, enough off-topic talk :-)
