Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send mail via any SMTP or sendmail server #379

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

michaelstorm
Copy link
Contributor

This allows the :via_options parameter to Pony.mail() to be set in environment.rb, which in turn allows Barkeep's mail to be delivered via our internal Exchange server. The default Gmail settings still work fine. It also lets you authenticate with a different username than you send mail with.

I also added the SINGLE_OUTGOING_MAIL_ADDRESS variable, which disables the "+commits", "+comments" and "+requests" suffixes when set to true. Our mail server, by default, doesn't let users send mail with a different outgoing address than their own. So it's one less permissions headache for me, when you're just trying Barkeep out :-).

Mike

… for outgoing mail, when mail server permissions make it necessary.
@philc
Copy link
Contributor

philc commented Dec 29, 2012

Nice Michael, thanks for extending our mail setup. The next step is to give some thought on how to integrate something like this alongside the other configuration options that Barkeep takes. You'll notice that currently environment.rb is a simple list of key value pairs where values are all strings so that they can be filled in by Fezzik, our deployment framework, and your PR introduces a value that is a hash.

If we decouple all of the deployment code of Barkeep as suggested here then we'll probably revisit how we do configuration.

…config constants for outgoing mail addresses.
@michaelstorm
Copy link
Contributor Author

Fixed in d95c27a; my mistake. Ruby isn't a primary language of mine, so I'm sorry if the fix is unidiomatic. I'm also worried about the MAIL_USER and MAIL_DOMAIN variables engendering confusion, since they're not used outside of environment.rb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants