Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor imports to use @/ alias. #2824

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Refactor imports to use @/ alias. #2824

merged 2 commits into from
Sep 11, 2024

Conversation

pygeek
Copy link
Contributor

@pygeek pygeek commented Sep 10, 2024 •
edited
Loading

Refactor imports (under @/) to eliminate ambiguity and namespace clobbering. Some local imports still use ./ and ../).

Related to: #2815

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

Uffizzi Preview deployment-56128 was deleted.

@pygeek pygeek force-pushed the absolute-imports branch 2 times, most recently from 4263fab to 48e4c2b Compare September 10, 2024 22:16
@pygeek pygeek force-pushed the absolute-imports branch 4 times, most recently from 839157e to f629abe Compare September 10, 2024 22:50
GreenAsJade
GreenAsJade reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@GreenAsJade GreenAsJade left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this branch in, it runs fine, and VSCode groks it all.

There's one prettier issue, that's all.

src/components/Markdown/Markdown.tsx Outdated Show resolved Hide resolved
GreenAsJade
GreenAsJade approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@GreenAsJade GreenAsJade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good - I pulled this branch ran it, and it runs fine, IDE groks all the changes.

@anoek anoek merged commit fdd9d01 into online-go:devel Sep 11, 2024
4 checks passed
@pygeek pygeek deleted the absolute-imports branch September 13, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GreenAsJade GreenAsJade GreenAsJade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pygeek @GreenAsJade @anoek