Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More GoEngine tests #141

Merged
merged 14 commits into from
Nov 27, 2023
Merged

More GoEngine tests #141

merged 14 commits into from
Nov 27, 2023

Conversation

benjaminpjones
Copy link
Contributor

@benjaminpjones benjaminpjones commented Nov 24, 2023

Raises GoEngine.ts test coverage from 67% to 77% (62% -> 64% globally)

Still missing a lot of edge cases, but at least this gets the happy path for a lot of GoEngine methods :)

Notes:

  • the deleted file GoEngine_computeScore.test.ts was merged into the larger GoEngine.test.ts file.
  • Also the commit messages aren't so precise on this one - let me know if I should just rebase. I figure commit granularity isn't so important this time since these are just tests, not production code.

@anoek
Copy link
Member

anoek commented Nov 27, 2023

Awesome, thanks for the tests!

@anoek anoek merged commit b04835c into online-go:main Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants