Score estimator more cleanup #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks to be a holdover from when this code was copied from GoEngine. It no longer applies, and this code is hit every time we score a group of territory.
benjaminpjones
force-pushed
the
score-estimator-more-cleanup
branch
from
b38e831 to
02d229f
Compare
I also needed to update a test which was pointed at the wrong variable. In the future, we can probably get rid of some of the mocking in the test that makes it brittle.
benjaminpjones
force-pushed
the
score-estimator-more-cleanup
branch
from
02d229f to
ecf3284
Compare
|
Thank goodness for static analysis! I removed the commit to get rid of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few more cleanup opportunities that became apparent after spending more time with the ScoreEstimator code.