Implement MVP Share UI as designed #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that shows number of items, total file size and Clear All button
akwizgran
reviewed
Nov 19, 2021
app/src/main/java/org/onionshare/android/server/WebserverManager.kt
Outdated
Show resolved
Hide resolved
| } | ||
| return FilesAdded(existingFiles + files) | ||
| } | ||
|
|
||
| fun zipFiles(state: FilesAdded): FilesReadyForDownload { | ||
| fun zipFiles(files: List<SendFile>, ensureActive: () -> Unit): FilesReadyForDownload { |
There was a problem hiding this comment.
Rather than passing a lambda that wraps the coroutine scope's ensureActive() method, I wonder if it might be clearer to pass the coroutine scope and call its ensureActive() method explicitly? I think that would make it more obvious that the lambda is expected to throw CancellationException to break the loop.
There was a problem hiding this comment.
That is actually how it was before. I had changed it, because I found it a bit strange to hand over coroutine contexts in a function, but maybe that's fine.
What might be better and seems to be possible is using currentCoroutineContext().ensureActive() which can be done when we make this a suspend function.
app/src/main/java/org/onionshare/android/server/WebserverManager.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.