Merge pull request #144 from emaslak/standard_2.1

Updated bundle to use strict standard ~2.1.
ongr-io · May 18, 2015 · 0ef9e2a · 0ef9e2a
2 parents 97c853d + 8655f67
commit 0ef9e2a
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 11 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -15,4 +15,4 @@ before_script:
   - composer update --prefer-dist
 script:
   - vendor/bin/phpunit
-  - vendor/bin/phpcs -p --standard=$TRAVIS_BUILD_DIR/vendor/ongr/ongr-strict-standard/ONGR --ignore=vendor/,Tests/app/,Resources/public/ ./
+  - vendor/bin/phpcs -p --standard=vendor/ongr/ongr-strict-standard/Ongr --ignore=vendor/,Tests/app/,Resources/public/ ./
diff --git a/FlashBag/DirtyFlashBag.php b/FlashBag/DirtyFlashBag.php
@@ -78,7 +78,7 @@ public function add($type, $message)
      * {@inheritdoc}
      *
      * @param string $type
-     * @param array $default
+     * @param array  $default
      */
     public function get($type, array $default = [])
     {
@@ -113,7 +113,7 @@ public function all()
      * {@inheritdoc}
      *
      * @param string $type
-     * @param array $messages
+     * @param array  $messages
      */
     public function set($type, $messages)
     {

diff --git a/Tests/Fixtures/Security/LoginTestHelper.php b/Tests/Fixtures/Security/LoginTestHelper.php
@@ -37,7 +37,7 @@ public function __construct(Client $client)
      * @param string $username
      * @param string $password
      *
-     * @return Client $client
+     * @return Client
      */
     public function loginAction($username = 'test', $password = 'test')
     {

diff --git a/Tests/Functional/Settings/Personal/PersonalProfilesProviderTest.php b/Tests/Functional/Settings/Personal/PersonalProfilesProviderTest.php
@@ -35,7 +35,7 @@ public function testGetPersonalProfilesProvider()
     /**
      * Get Container.
      *
-     * @return Service container
+     * @return Service Service container.
      */
     protected function getServiceContainer()
     {

diff --git a/Tests/Unit/DependencyInjection/ConfigurationTest.php b/Tests/Unit/DependencyInjection/ConfigurationTest.php
@@ -31,7 +31,6 @@ public function configurationData()
         ];
 
         // A #0 test default values.
-
         $out[] = [
             [],
             [

diff --git a/Tests/Unit/Twig/ImagePathExtensionTest.php b/Tests/Unit/Twig/ImagePathExtensionTest.php
@@ -11,7 +11,6 @@
 
 namespace ONGR\SettingsBundle\Tests\Functional\Twig;
 
-use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 use ONGR\SettingsBundle\Twig\ImagePathExtension;
 
 class ImagePathExtensionTest extends \PHPUnit_Framework_TestCase
@@ -103,7 +102,7 @@ public function testGetImagePathExceptionPreset()
     }
 
     /**
-     *Tests get image path part.
+     * Tests get image path part.
      *
      * @covers \ONGR\SettingsBundle\Twig\ImagePathExtension::getImagePath()
      *

diff --git a/Twig/WrapperExtension.php b/Twig/WrapperExtension.php
@@ -87,7 +87,7 @@ public function wrap($text, $keywords, $prefix = '<strong>', $suffix = '</strong
     /**
      * Returns the name of the extension.
      *
-     * @return string The extension name
+     * @return string The extension name.
      */
     public function getName()
     {

diff --git a/composer.json b/composer.json
@@ -25,8 +25,8 @@
     },
     "require-dev": {
         "phpunit/phpunit": "~4.2",
-        "squizlabs/php_codesniffer": "~1.5",
-        "ongr/ongr-strict-standard": "~1.0"
+        "squizlabs/php_codesniffer": "~2.0",
+        "ongr/ongr-strict-standard": "~2.1"
     },
     "autoload": {
         "psr-4": { "ONGR\\SettingsBundle\\": "" }
-Original file line number
+Diff line change
@@ Expand Up / @@ -31,7 +31,6 @@ public function configurationData() @@
             ];
             // A #0 test default values.
             $out[] = [
                 [],
                 [
@@ Expand Down @@