-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Interaction Template generation/query & display for transactions generated by NFT Catalog #97
base: main
Are you sure you want to change the base?
Conversation
… generated by NFT Catalog
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
useEffect(() => { | ||
async function getInteractionTemplateAudits() { | ||
if (interactionTemplateData) { | ||
const auditors = await fetch(`https://flix.flow.com/v1/auditors?network=${network}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this data is relatively static? Does the FLIX API serve the necessary Cache-Control
logic to allow the browser to cache this locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea this endpoint is fairly static! The API also sits behind a cache. I'll look into the FLIX API to be sure we're setting the correct headers!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR Jeff!
For a lot of the interaction templates, I get back a This transaction is not supported
or something similar. Can we choose to say that before making the API call to generate? It's a somewhat frustrating UX as it is IMO. Also explaining why a TX can or can't be used as an interaction template at some point might be useful to help educate developers about the system, and how its used.
Hey @aishairzay The error: |
Is there a way we can not have an error? Or at a minimum predict if there will be an error prior to the API call and not give the generate interaction template option if so? Goal here is to make this a seamless process rather than confuse developers |
Adds Interaction Template generation/query & display for transactions generated by NFT Catalog