Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to update symbols in bridged ERC20/721 contracts #118

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Sep 3, 2024

Related: #117

ℹ️ Changes will be required on the Cadence side to complete the functionality programattically, but those changes will be updatable and can be addressed in a subsequent PR

Description

  • Adds methods to bridged ERC20/721 templates for the bridge COA to update asset symbols
  • Updates any relevant bytecode for ERC20/721 deployers which are responsible for deploying these templates as commanded by the Cadence side of the bridge

For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base (ce09dd2) to head (8902cab).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   86.77%   86.77%           
=======================================
  Files          18       18           
  Lines         953      953           
=======================================
  Hits          827      827           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review September 3, 2024 23:02
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner September 3, 2024 23:02
@sisyphusSmiling sisyphusSmiling merged commit ca95d45 into main Sep 3, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the enable-symbol-updates branch September 3, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants